-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactory CognitiveServicesAccount model specification. #7415
Conversation
In Testing, Please Ignore[Logs] (Generated from 7a341e3, Iteration 9)
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Addition of properties, requesting arm review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are breaking changes.
...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json
Show resolved
Hide resolved
...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json
Show resolved
Hide resolved
...s/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/examples/CreateAccount.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off
Hi @anuchandy , the PR got ARM sign off, can you help to do a final review/merge? |
HI @yangyuan is this PR ready to merge? HI @anuchandy could you pls review and merge the PR? thanks. |
Changing the input model type from |
Refine the description of
CognitiveServicesAccount
model.. No changes in service side.Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.