Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactory CognitiveServicesAccount model specification. #7415

Merged
merged 2 commits into from Oct 21, 2019
Merged

Refactory CognitiveServicesAccount model specification. #7415

merged 2 commits into from Oct 21, 2019

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Oct 7, 2019

Refine the description of CognitiveServicesAccount model.. No changes in service side.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@yangyuan yangyuan requested a review from DavidLiCIG as a code owner October 7, 2019 21:49
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 7, 2019

In Testing, Please Ignore

[Logs] (Generated from 7a341e3, Iteration 9)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning cognitiveservices/resource-manager/v2016_02_01_preview [Logs]
  • Failed cognitiveservices/resource-manager/v2017_04_18 [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Oct 7, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7669

@AutorestCI
Copy link

AutorestCI commented Oct 7, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6101

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy
Copy link
Member

Addition of properties, requesting arm review.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are breaking changes.

@KrisBash KrisBash added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 8, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off

@yangyuan
Copy link
Member Author

Hi @anuchandy , the PR got ARM sign off, can you help to do a final review/merge?

@yungezz
Copy link
Member

yungezz commented Oct 21, 2019

HI @yangyuan is this PR ready to merge? HI @anuchandy could you pls review and merge the PR? thanks.

@anuchandy
Copy link
Member

Changing the input model type from CognitiveServicesAccountUpdateParameters to CognitiveServicesAccount is a SDK breaking change. I've added the potential-sdk-breaking-change tag so that sdk can bump up it's version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants