Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move cns from servercore to nanoserver #2454

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: move cns from servercore to nanoserver #2454

merged 1 commit into from
Aug 19, 2024

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Dec 19, 2023 •
edited
Loading

Reason for Change:

servercore has idle overhead of ~230 MB of memory and a base image size ~2 GB, vs nanoserver's idle overhead of ~90 MB of memory and base image size around 250 MB. Given CNS image pull-time impacts node readiness, VHD space constraints, and recent issues and heightened awareness of memory usage on Windows, migrate to the lighter base image 🙂

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested a review from a team as a code owner December 19, 2023 23:28
@rbtr rbtr self-assigned this Dec 19, 2023
jpayne3506
jpayne3506 reviewed Dec 19, 2023
View reviewed changes
cns/windows.Dockerfile Outdated Show resolved Hide resolved
@rbtr rbtr requested a review from nddq December 19, 2023 23:42
@rbtr rbtr added the cns Related to CNS. label Dec 19, 2023
@rbtr rbtr enabled auto-merge December 20, 2023 03:56
@rbtr
Copy link
Contributor Author

rbtr commented Dec 20, 2023

duplicate of #1944

@rbtr rbtr closed this Dec 20, 2023
auto-merge was automatically disabled December 20, 2023 16:24

Pull request was closed

@rbtr rbtr deleted the chore/cns-nanoserver branch December 20, 2023 16:24
@rbtr rbtr added the duplicate label Dec 20, 2023
@rbtr rbtr restored the chore/cns-nanoserver branch December 20, 2023 17:02
@rbtr
Copy link
Contributor Author

rbtr commented Dec 20, 2023

reopen since #1944 is from a fork

@rbtr rbtr reopened this Dec 20, 2023
@rbtr rbtr mentioned this pull request Dec 20, 2023
Closed
3 tasks
nddq
nddq previously approved these changes Dec 20, 2023
View reviewed changes
@rbtr rbtr enabled auto-merge December 20, 2023 18:24
@rbtr rbtr removed the duplicate label Dec 20, 2023
@rbtr rbtr force-pushed the chore/cns-nanoserver branch from 0d57570 to afacc6f Compare December 20, 2023 21:50
@rbtr rbtr added this pull request to the merge queue Dec 20, 2023
@jpayne3506 jpayne3506 removed this pull request from the merge queue due to a manual request Dec 20, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@rbtr rbtr closed this Jan 3, 2024
@rbtr rbtr deleted the chore/cns-nanoserver branch January 3, 2024 17:56
@rbtr rbtr restored the chore/cns-nanoserver branch August 15, 2024 16:15
@rbtr rbtr reopened this Aug 15, 2024
@rbtr rbtr added this pull request to the merge queue Aug 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2024
@rbtr rbtr added this pull request to the merge queue Aug 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2024
@nddq nddq added this pull request to the merge queue Aug 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2024
@rbtr rbtr added this pull request to the merge queue Aug 19, 2024
@rbtr
feat: migrate CNS Windows to nanoserver and pin all SHAs
e5782b3 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr removed this pull request from the merge queue due to a manual request Aug 19, 2024
@rbtr rbtr dismissed stale reviews from jpayne3506 and nddq via e5782b3 August 19, 2024 15:53
@rbtr rbtr force-pushed the chore/cns-nanoserver branch from 0a34276 to e5782b3 Compare August 19, 2024 15:53
@rbtr rbtr requested review from jpayne3506 and nddq August 19, 2024 15:53
@rbtr
Copy link
Contributor Author

rbtr commented Aug 19, 2024

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nddq nddq added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit 4902139 Aug 19, 2024
11 checks passed
@nddq nddq deleted the chore/cns-nanoserver branch August 19, 2024 18:33
rbtr added a commit that referenced this pull request Aug 20, 2024
@rbtr
backport: chore: move cns from servercore to nanoserver (#2454)
a184335 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr added a commit that referenced this pull request Aug 20, 2024
@rbtr
backport: chore: move cns from servercore to nanoserver (#2454)
fd9e8b2 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
@rbtr
backport: chore: move cns from servercore to nanoserver (#2454) (#2936)
3d3634d 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr added a commit that referenced this pull request Aug 26, 2024
@rbtr
backport: chore: move cns from servercore to nanoserver (#2454)
2f1994e 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr added a commit that referenced this pull request Aug 30, 2024
@rbtr
backport: chore: move cns from servercore to nanoserver (#2454) (#2935)
73a0919 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
thatmattlong added a commit that referenced this pull request Oct 23, 2024
@thatmattlong
Revert "backport: chore: move cns from servercore to nanoserver (#2454)…
8b531ba 
… (#2935)"

This reverts commit 73a0919.
jpayne3506 pushed a commit that referenced this pull request Nov 1, 2024
@thatmattlong @jpayne3506
Revert "backport: chore: move cns from servercore to nanoserver (#2454)…
e683adf 
… (#2935)"

This reverts commit 73a0919.
rbtr pushed a commit that referenced this pull request Nov 4, 2024
@thatmattlong
Revert "backport: chore: move cns from servercore to nanoserver (#2454)…
7081b69 
…" (#3084)

Revert "backport: chore: move cns from servercore to nanoserver (#2454) (#2935)"

This reverts commit 73a0919.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@nddq nddq nddq approved these changes

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner automatically assigned from Azure/acn-cns-reviewers

@vipul-21 vipul-21 Awaiting requested review from vipul-21 vipul-21 is a code owner automatically assigned from Azure/acn-cni-reviewers

@paulyufan2 paulyufan2 Awaiting requested review from paulyufan2

Assignees

@rbtr rbtr

Labels
cns Related to CNS. needs-backport Change needs to be backported to previous release trains
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbtr @jpayne3506 @nddq