Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing from windows servercore to nanoserver #1944

Closed
wants to merge 1 commit into from
Closed

Changing from windows servercore to nanoserver #1944

wants to merge 1 commit into from

Conversation

alam-tahmid
Copy link
Contributor

@alam-tahmid alam-tahmid commented May 4, 2023 •
edited
Loading

Reason for Change:

Smaller image size

Issue Fixed:

Requirements:

Notes:

@alam-tahmid alam-tahmid requested a review from a team as a code owner May 4, 2023 22:13
@alam-tahmid alam-tahmid requested review from thatmattlong and removed request for a team May 4, 2023 22:13
@rbtr rbtr added cns Related to CNS. windows labels May 5, 2023
@rbtr
Copy link
Contributor

rbtr commented May 5, 2023

@matmerr how did you experiment with changing this for NPM go? Anything we should be aware of when doing it for CNS?

rbtr
rbtr approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI

@rbtr rbtr enabled auto-merge (squash) May 8, 2023 15:37
@rbtr rbtr force-pushed the tahmidalam/chagnedToWindowsNanoserver branch from b1629c2 to 099bdf5 Compare June 9, 2023 17:25
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Aug 9, 2023
@alam-tahmid alam-tahmid force-pushed the tahmidalam/chagnedToWindowsNanoserver branch 2 times, most recently from 74c2ef8 to 4fe6349 Compare August 10, 2023 20:41
@alam-tahmid alam-tahmid disabled auto-merge August 10, 2023 20:41
@alam-tahmid alam-tahmid enabled auto-merge (squash) August 10, 2023 21:59
@github-actions github-actions bot removed the stale Stale due to inactivity. label Aug 11, 2023
@rbtr rbtr force-pushed the tahmidalam/chagnedToWindowsNanoserver branch from aacf228 to 4a8141c Compare August 23, 2023 17:11
@alam-tahmid alam-tahmid marked this pull request as draft September 5, 2023 20:28
auto-merge was automatically disabled September 5, 2023 20:28

Pull request was converted to draft

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Nov 5, 2023
@nddq nddq force-pushed the tahmidalam/chagnedToWindowsNanoserver branch from 4a8141c to 180e352 Compare November 5, 2023 03:50
@github-actions github-actions bot removed the stale Stale due to inactivity. label Nov 6, 2023
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Dec 20, 2023
@rbtr rbtr marked this pull request as ready for review December 20, 2023 16:22
@rbtr rbtr force-pushed the tahmidalam/chagnedToWindowsNanoserver branch from 180e352 to 64e5516 Compare December 20, 2023 16:22
@rbtr rbtr enabled auto-merge December 20, 2023 16:22
@rbtr rbtr disabled auto-merge December 20, 2023 16:23
@rbtr rbtr enabled auto-merge December 20, 2023 16:23
@rbtr rbtr mentioned this pull request Dec 20, 2023
Merged
4 tasks
@rbtr
Copy link
Contributor

rbtr commented Dec 20, 2023

closing due to fork, in favor of #2454

@rbtr rbtr closed this Dec 20, 2023
auto-merge was automatically disabled December 20, 2023 17:03

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nairashu nairashu nairashu approved these changes

@rbtr rbtr rbtr approved these changes

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees
No one assigned
Labels
cns Related to CNS. stale Stale due to inactivity. windows work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alam-tahmid @rbtr @nairashu