Revert "backport: chore: move cns from servercore to nanoserver (#2454)" #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nairashu
approved these changes
Oct 23, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nairashu
approved these changes
Oct 30, 2024
rbtr
reviewed
Oct 31, 2024
27faf59 to
8b531ba
Compare
|
/azp run Azure Container Networking PR |
rbtr
approved these changes
Oct 31, 2024
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I will bypass CRD Gen, I don't think we should change it in this revert PR |
8b531ba to
e683adf
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2935
CNS Daemonset on AKS does not have a volume mount for powershell, seemingly due to to Azure/AKS#3885, so we need to keep using servercore on v1.4 branch until we add a volume mount to host powershell