-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new mnemonic deployments on sepolia #12076
Conversation
.github/workflows/network-deploy.yml
Outdated
if: ${{ inputs.sepolia_deployment == 'true' }} | ||
run: | | ||
REPO=$(git rev-parse --show-toplevel) | ||
export MNEMONIC=$(bash $REPO/spartan/scripts/prepare_sepolia_accounts.sh 1117 100 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a mask? or is it already masked
cspell.json
Outdated
"tparam", | ||
"transferables", | ||
"transitioner", | ||
"trivago", | ||
"tsbuildinfo", | ||
"tsdoc", | ||
"txes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deliberate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, cspell annotations annoy me so I add stuff 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh just saw that it was already there 😬 . Seems my editor fixed alphabetic arrangemenet & removed duplicates
|
||
multicall_address="0xcA11bde05977b3631167028862bE2a173976CA11" # Sepolia Multicall3 contract | ||
|
||
TX_HASH=$(cast send "$multicall_address" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah multicall for this is nice
spartan/scripts/output.json
Outdated
@@ -0,0 +1,21 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deliberate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
4191f0b
to
43203a0
Compare
|
||
if [ "$sepolia_run" = "true" ]; then | ||
# Read the mnemonic from file mnemonic.tmp | ||
l1_account_mnemonic=$(cat mnemonic.tmp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up there's a -x
above in the file that may leak this. I'd set a +x
around here to make sure it's not shown in logs.
|
||
# Add account - use private key if set, otherwise use mnemonic | ||
if [ -n "${L1_DEPLOYMENT_PRIVATE_KEY:-}" ]; then | ||
base_cmd="$base_cmd --private-key $L1_DEPLOYMENT_PRIVATE_KEY" | ||
else | ||
base_cmd="$base_cmd --mnemonic '$MNEMONIC'" | ||
base_cmd="$base_cmd --mnemonic '$MNEMONIC' --test-accounts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come you only want test accounts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately, I have a PR that just pulls this into the aztec.testAccounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh must've added this by mistake, will remove thx 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait nvm now I see what I did.. we don't have test accounts for sepolia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this "test accounts" is referring to L2 test accounts. It impacts the genesis state in the rollup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah mb thought it was for L1 genesis state. And this doesn't need anything different done in L1? will add back
# Convert ETH to wei | ||
wei_amount=$(cast to-wei "$eth_amount" ether) | ||
|
||
# Get current gas price and add 50% buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: busted comment?
labels: | ||
{{- include "aztec-network.labels" . | nindent 4 }} | ||
annotations: | ||
"helm.sh/hook": pre-delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we rather want post-delete
? It looks like pre-delete runs in response to any resource getting deleted, but we probably want to consolidate funds after everything has been cleaned up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, updating!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
* master: (31 commits) feat: Slack message to ci channel tagging owners on flakes. (#12284) fix: slack notify was broken by quoted commit titles revert: "chore: Fix and reenable fees-settings test (#12302)" fix: run arm64 on master (#12307) yolo fix chore: Fix and reenable fees-settings test (#12302) feat!: rename compute_nullifier_without_context (#12308) chore: Lazy loading artifacts everywhere (#12285) chore: Reenable dapp subscription test (#12304) chore: Run prover test with fake proofs when requested (#12305) chore: Do not set CI_FULL outside CI (#12300) chore: new mnemonic deployments on sepolia (#12076) chore!: enable multiple L1 nodes to be used (#11945) chore: remove no longer supported extension from vscode/extension.json (#12303) fix(e2e): p2p_reqresp (#12297) feat: Sync from noir (#12298) chore: enabling `e2e_contract_updates` in CI + nuking irrelevant test (#12293) feat: prepend based merge (#12093) feat: fetch addresses from registry (#12000) feat: live logs (#12271) ...
Fixes #11765
Updating how we make sepolia deployments on k8s.
Instead of fixed pre-funded addresses, we have a single private key that funds new addresses for each new deployment.
Also fixes setting up the transaction bot for sepolia deployments