Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new mnemonic deployments on sepolia #12076

Merged
merged 16 commits into from
Feb 26, 2025
Merged

chore: new mnemonic deployments on sepolia #12076

merged 16 commits into from
Feb 26, 2025

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Feb 18, 2025

Fixes #11765
Updating how we make sepolia deployments on k8s.
Instead of fixed pre-funded addresses, we have a single private key that funds new addresses for each new deployment.
Also fixes setting up the transaction bot for sepolia deployments

@spypsy spypsy marked this pull request as ready for review February 18, 2025 14:36
@spypsy spypsy requested a review from charlielye as a code owner February 18, 2025 14:36
if: ${{ inputs.sepolia_deployment == 'true' }}
run: |
REPO=$(git rev-parse --show-toplevel)
export MNEMONIC=$(bash $REPO/spartan/scripts/prepare_sepolia_accounts.sh 1117 100 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a mask? or is it already masked

cspell.json Outdated
"tparam",
"transferables",
"transitioner",
"trivago",
"tsbuildinfo",
"tsdoc",
"txes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deliberate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, cspell annotations annoy me so I add stuff 😬

Copy link
Member Author

@spypsy spypsy Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh just saw that it was already there 😬 . Seems my editor fixed alphabetic arrangemenet & removed duplicates


multicall_address="0xcA11bde05977b3631167028862bE2a173976CA11" # Sepolia Multicall3 contract

TX_HASH=$(cast send "$multicall_address" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah multicall for this is nice

@@ -0,0 +1,21 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deliberate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@spypsy spypsy force-pushed the spy/ad-hoc-sepolia branch from 4191f0b to 43203a0 Compare February 19, 2025 13:33

if [ "$sepolia_run" = "true" ]; then
# Read the mnemonic from file mnemonic.tmp
l1_account_mnemonic=$(cat mnemonic.tmp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up there's a -x above in the file that may leak this. I'd set a +x around here to make sure it's not shown in logs.

@spypsy spypsy requested a review from Maddiaa0 February 26, 2025 10:18
@spypsy spypsy requested a review from just-mitch February 26, 2025 14:38

# Add account - use private key if set, otherwise use mnemonic
if [ -n "${L1_DEPLOYMENT_PRIVATE_KEY:-}" ]; then
base_cmd="$base_cmd --private-key $L1_DEPLOYMENT_PRIVATE_KEY"
else
base_cmd="$base_cmd --mnemonic '$MNEMONIC'"
base_cmd="$base_cmd --mnemonic '$MNEMONIC' --test-accounts"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you only want test accounts here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, I have a PR that just pulls this into the aztec.testAccounts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh must've added this by mistake, will remove thx 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait nvm now I see what I did.. we don't have test accounts for sepolia

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this "test accounts" is referring to L2 test accounts. It impacts the genesis state in the rollup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah mb thought it was for L1 genesis state. And this doesn't need anything different done in L1? will add back

# Convert ETH to wei
wei_amount=$(cast to-wei "$eth_amount" ether)

# Get current gas price and add 50% buffer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: busted comment?

labels:
{{- include "aztec-network.labels" . | nindent 4 }}
annotations:
"helm.sh/hook": pre-delete
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we rather want post-delete? It looks like pre-delete runs in response to any resource getting deleted, but we probably want to consolidate funds after everything has been cleaned up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, updating!

Copy link
Collaborator

@just-mitch just-mitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@spypsy spypsy enabled auto-merge (squash) February 26, 2025 19:10
@spypsy spypsy merged commit 62faad5 into master Feb 26, 2025
9 checks passed
@spypsy spypsy deleted the spy/ad-hoc-sepolia branch February 26, 2025 19:23
TomAFrench added a commit that referenced this pull request Feb 26, 2025
* master: (31 commits)
  feat: Slack message to ci channel tagging owners on flakes. (#12284)
  fix: slack notify was broken by quoted commit titles
  revert: "chore: Fix and reenable fees-settings test (#12302)"
  fix: run arm64 on master (#12307)
  yolo fix
  chore: Fix and reenable fees-settings test (#12302)
  feat!: rename compute_nullifier_without_context (#12308)
  chore: Lazy loading artifacts everywhere (#12285)
  chore: Reenable dapp subscription test (#12304)
  chore: Run prover test with fake proofs when requested (#12305)
  chore: Do not set CI_FULL outside CI (#12300)
  chore: new mnemonic deployments on sepolia (#12076)
  chore!: enable multiple L1 nodes to be used (#11945)
  chore: remove no longer supported extension from vscode/extension.json (#12303)
  fix(e2e): p2p_reqresp (#12297)
  feat: Sync from noir (#12298)
  chore: enabling `e2e_contract_updates` in CI + nuking irrelevant test (#12293)
  feat: prepend based merge (#12093)
  feat: fetch addresses from registry (#12000)
  feat: live logs (#12271)
  ...
just-mitch pushed a commit that referenced this pull request Mar 3, 2025
Follow-up fixes from merging #11945 & #12076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faucet setup for funding test accounts
4 participants