Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enabling e2e_contract_updates in CI + nuking irrelevant test #12293

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Feb 26, 2025

e2e_contract_updates test was not enabled in CI by accident and the e2e_new_addresses test is no longer relevant.

Checked the CI run and the test got executed:
image

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan marked this pull request as ready for review February 26, 2025 16:05
@benesjan benesjan requested a review from charlielye as a code owner February 26, 2025 16:05
@benesjan benesjan requested a review from spalladino February 26, 2025 16:44
@benesjan benesjan enabled auto-merge (squash) February 26, 2025 16:44
@benesjan benesjan merged commit cc0130a into master Feb 26, 2025
11 of 13 checks passed
@benesjan benesjan deleted the 02-26-chore_enabling_e2e_contract_updates_in_ci_nuking_irrelevant_test branch February 26, 2025 18:12
TomAFrench added a commit that referenced this pull request Feb 26, 2025
* master: (31 commits)
  feat: Slack message to ci channel tagging owners on flakes. (#12284)
  fix: slack notify was broken by quoted commit titles
  revert: "chore: Fix and reenable fees-settings test (#12302)"
  fix: run arm64 on master (#12307)
  yolo fix
  chore: Fix and reenable fees-settings test (#12302)
  feat!: rename compute_nullifier_without_context (#12308)
  chore: Lazy loading artifacts everywhere (#12285)
  chore: Reenable dapp subscription test (#12304)
  chore: Run prover test with fake proofs when requested (#12305)
  chore: Do not set CI_FULL outside CI (#12300)
  chore: new mnemonic deployments on sepolia (#12076)
  chore!: enable multiple L1 nodes to be used (#11945)
  chore: remove no longer supported extension from vscode/extension.json (#12303)
  fix(e2e): p2p_reqresp (#12297)
  feat: Sync from noir (#12298)
  chore: enabling `e2e_contract_updates` in CI + nuking irrelevant test (#12293)
  feat: prepend based merge (#12093)
  feat: fetch addresses from registry (#12000)
  feat: live logs (#12271)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants