fix: sepolia deployments #12329
Merged
fix: sepolia deployments #12329
+55
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678a71b to
ed47234
Compare
Maddiaa0
reviewed
Feb 27, 2025
| @@ -84,11 +84,6 @@ on: | |||
| required: false | |||
| type: string | |||
| default: "false" | |||
| ref: | |||
There was a problem hiding this comment.
I would like to keep this please, otherwise the values file needs to be in master in order to test a deployment.
There was a problem hiding this comment.
unless the github.ref below does the same thing in that case all gucci
There was a problem hiding this comment.
yesss workflow dispatch actions have this by default, we don't need an extra input of our own
just-mitch
reviewed
Mar 3, 2025
| cast wallet new-mnemonic --accounts "$num_accounts" --json >output.json | ||
| MNEMONIC=$(jq -r '.mnemonic' output.json) | ||
| ADDRESSES=$(jq -r '.accounts[].address' output.json) | ||
| rm output.json |
There was a problem hiding this comment.
security nit: it's probably safer to put cleanup like this in a traped cleanup function.
just-mitch
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up fixes from merging #11945 & #12076