Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related Posts Styles in TwentyTwenty #14066

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Related Posts Styles in TwentyTwenty #14066

merged 2 commits into from
Nov 18, 2019

Conversation

scottsweb
Copy link
Contributor

@scottsweb scottsweb commented Nov 18, 2019 •
edited
Loading

This PR supersedes: #14023
Fixes #14020

Changes proposed in this Pull Request:

  • Fix related posts module styles in TwentyTwenty, use widths and sizes that are similar to the theme.
  • Fix a bug in the GIF block which impacts the position of that block in TwentyTwenty

Testing instructions:

  • Enable TwentyTwenty
  • Use the GIF block and test the output on the front end of the site
  • Create a number of related posts (in the same category)
  • Ensure related posts are turned on
  • Open one of the posts and test the related post module at the bottom of the site.

It should look like this:

Screenshot 2019-11-18 at 16 14 39

I have given it the same width as the footer area below the post, it uses the same widths and sizes provided by the theme. It also behaves more similarly to the inline related posts block (using flexbox rather than floats).

Proposed changelog entry for your changes:

  • Improve TwentyTwenty compatibility

@scottsweb scottsweb added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Theme Tools [Feature] Related Posts [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Cherry-Pick labels Nov 18, 2019
@scottsweb scottsweb requested review from jeherve and a team November 18, 2019 16:23
@scottsweb scottsweb mentioned this pull request Nov 18, 2019
Closed
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 19, 2019.
Scheduled code freeze: November 12, 2019

Generated by 🚫 dangerJS against 675786b

@jeherve jeherve added this to the 7.9.1 milestone Nov 18, 2019
jeherve
jeherve approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well for me. Merging.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 18, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scottsweb! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D35609-code before merging this PR. Thank you!

@jeherve
Copy link
Member

jeherve commented Nov 18, 2019

I'll take care of Fusion as well.

@jeherve jeherve merged commit eefec20 into master Nov 18, 2019
@jeherve jeherve deleted the fix/14020-twentytwenty-block-styles branch November 18, 2019 18:02
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 18, 2019
jeherve pushed a commit that referenced this pull request Nov 18, 2019
@scottsweb @jeherve
[not verified] Related Posts Styles in TwentyTwenty (#14066)
5714552 
* Fixes for related posts module in twentytwenty

* Fixes for GIF block CSS in twentytwenty
@jeherve
Copy link
Member

jeherve commented Nov 18, 2019

Cherry-picked to branch-7.9 in 5714552

jeherve added a commit that referenced this pull request Nov 18, 2019
@jeherve
Changelog: add #14066
d771eb6
jeherve added a commit that referenced this pull request Nov 18, 2019
@jeherve
Changelog: add 7.9.1 release (#14044)
a4aa134 
* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066
jeherve added a commit that referenced this pull request Nov 18, 2019
@jeherve
Changelog: add 7.9.1 release (#14044)
af270e9 
* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066
@nielslange nielslange mentioned this pull request Nov 18, 2019
Closed
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@scottsweb scottsweb

@nielslange nielslange

Labels
[Feature] Related Posts [Feature] Theme Tools Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9.1
Development

Successfully merging this pull request may close these issues.

Related Posts: Adjust margins due to WordPress 5.3
5 participants
@scottsweb @jetpackbot @matticbot @jeherve @nielslange