Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe Shortcode Updates #13841

Merged
merged 21 commits into from
Nov 19, 2019
Merged

Recipe Shortcode Updates #13841

merged 21 commits into from
Nov 19, 2019

Conversation

ChaosExAnima
Copy link
Contributor

Fixes #4470, #7878, #13660

Changes proposed in this Pull Request:

This updates the recipe shortcode as follows:

  • Adds Cooking Time, Prep Time, and Rating attributes to [recipe] shortcode.
  • Adds [recipe-nutrition] shortcode to allow for nutrition listing.
  • Adds [recipe-image] shortcode to control placement of recipe image.
  • Updates image output to allow for WordPress attachment as well as URL.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • p9dueE-14w-p2

Testing instructions:

  • Create a post with a recipe as per WP.com article
  • Add cookingtime, preptime, and rating attributes to recipe shortcode.
  • Add recipe-nutrition shortcode.
  • Add recipe-image shortcode with attachment ID.

Proposed changelog entry for your changes:

  • Enhances recipe shortcode with additional customization.

@ChaosExAnima ChaosExAnima added this to the 7.9 milestone Oct 25, 2019
@ChaosExAnima ChaosExAnima requested a review from a team October 25, 2019 19:57
@ChaosExAnima ChaosExAnima self-assigned this Oct 25, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello ChaosExAnima! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D34558-code before merging this PR. Thank you!

@ChaosExAnima ChaosExAnima added the [Tests] Needs Tests Some Unit Tests would be really useful to include with this PR. label Oct 25, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 25, 2019 •
edited
Loading

Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against d19e291

@matticbot
Copy link
Contributor

ChaosExAnima, Your synced wpcom patch D34558-code has been updated.

@ChaosExAnima ChaosExAnima modified the milestones: 7.9, 8.0 Oct 28, 2019
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Oct 28, 2019
@ChaosExAnima ChaosExAnima removed [Status] Needs Package Release This PR made changes to a package. Let's update that package now. [Tests] Needs Tests Some Unit Tests would be really useful to include with this PR. labels Oct 28, 2019
@matticbot
Copy link
Contributor

ChaosExAnima, Your synced wpcom patch D34558-code has been updated.

@ChaosExAnima
Copy link
Contributor Author

Messed up a bit in git history so had to rebase, thus all the not verified.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 8, 2019
@ChaosExAnima ChaosExAnima added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 12, 2019
@ChaosExAnima ChaosExAnima requested a review from jeherve November 12, 2019 21:34
@ChaosExAnima
Copy link
Contributor Author

@jeherve - I did some testing and fixes for the microformats markup. A few notes:

  • preptime and cooktime are indicated in the schema tester, but they appear to be Google exclusive extensions and not in the original spec. I got them as warnings but they aren't parseable.
  • description isn't working as expected and also a Google extension.

jeherve
jeherve approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@jeherve jeherve added [Status] Needs Testing We need to add this change to the testing call for this month's release [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 18, 2019
@matticbot
Copy link
Contributor

ChaosExAnima, Your synced wpcom patch D34558-code has been updated.

@ChaosExAnima ChaosExAnima merged commit 9265ccd into master Nov 19, 2019
@ChaosExAnima ChaosExAnima deleted the update/recipe-fixes branch November 19, 2019 17:24
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 19, 2019
@jeherve jeherve added [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Nov 25, 2019
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
Changelog: add #13841
d1953c5
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
This was referenced Nov 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@ChaosExAnima ChaosExAnima

Labels
[Feature] Shortcodes / Embeds Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

[Recipe] shortcode: add additional microformats support (v1 and v2)
5 participants
@ChaosExAnima @matticbot @jetpackbot @jeherve @kraftbj