Debugger: Modernize and increase timeout #13980
Conversation
…r connection check
|
As an aside, I'd like to work this into a package—would be great as a dependent on the connection package, but want to get this improvement in without having it be blocked by packaging. |
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: December 3, 2019. |
| * @return string The plan slug prepended with "JetpackPlan" | ||
| */ | ||
| private static function what_jetpack_plan() { | ||
| // Specifically not deprecating this function since it modifies the output of the Jetpack_Debug_Data::what_jetpack_plan return. |
There was a problem hiding this comment.
Is this okay to remove this now? The comment makes me worry. :)
There was a problem hiding this comment.
Yeah, that function provided some of the "debug data" that was part of the appended data when using the contact form that was built into Jetpack and all that debug data was legacy for WP versions prior to 5.2 (the old "Advanced Debug Results" link). The specific format of the text was required for Kayako/Zendesk processing to assign a plan value to a ticket.
For WP 5.2+, this stuff never displayed anywhere and with all private support requests going to the contact form (which uses the API and doesn't parse text anyhow), the plan output isn't needed here nor the legacy format that we needed to maintain.
* 8.0 Release: running changelog * Changelog: add #13921 * Changelog: add #13980 * Changelog: add #13905 * Changelog: add #13971 * Changelog: add #13984 * Changelog: add #14009 * Changelog: add #13620 * Remove things that will ship in 7.9.1 * Changelog: add 7.9.1 release (#14044) * Changelog: add base for 7.9.1 release * Update release date and post link * Changelog: add #14066 * Update changelog for 7.9.1 * Changelog: add #13405 * Changelog: add #13841 * Changelog: add #13924 * Changelog: add #13986 * Changelog: add #14010, #14028, #14053, #14055. * Changelog: add #14054 * Changelog: add #14031 * Changelog: add #14039 * Changelog: add #14050 * Changelog: add #14070 * Changelog: add #14082 * Changelog: add #14084 * Changelog: add #14111 * Changelog: add #13961 * Changelog: add #14047 * Changelog: add #14091 * Changelog: add #14108 * Changelog: add #14121
Fixes #12470
Adds a 30-second timeout to the other connection test method in the debug suite, pending actually getting that down to only one test.
Also removes pre-WP 5.2 era and pre-PHP 5.3 things that are no longer needed as soon as WP 5.3 ships (which will be before 8.0, so 8.0 will be bumping things to 5.2).
If we need to hold this until 5.2 as our minimum is official, that's fine.
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: