This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will merge after 2.8 compatibility is finished and stable. |
bump |
oldmud0
reviewed
Sep 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues:
/baninfo
won't retrieve a full ban history. Might need to add an index toooc_events
to speed up OOC name lookup.- Attaching an extra IPID/HDID to an existing ban using the
/ban <ipid> <ban_id>
syntax will not warn if that ban is no longer in force.
i specifically don't want to use the unban date to invalidate a ban so you can keep track of who was banned for how long, even after they get unbanned by the moderators i will work on the minor issues you listed soon |
oldmud0
reviewed
Jan 17, 2021
since #161 also increments the DB version we should combine the migration scripts |
I'm fine with this as long as it was well tested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this keeps past bans in the db so you can look up for what someone got banned in the past
it also shows displays the remaining ban time to the user in a more human readable formatthat was my other PRin 20 minutes instead of todays date
the WIP stuff is the database, i need to remove some UNIQUE constraints