Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Past bans #98

Merged
merged 12 commits into from
Mar 1, 2021
Merged

Past bans #98

merged 12 commits into from
Mar 1, 2021

Conversation

stonedDiscord
Copy link
Member

@stonedDiscord stonedDiscord commented Apr 13, 2020

this keeps past bans in the db so you can look up for what someone got banned in the past

it also shows displays the remaining ban time to the user in a more human readable format
in 20 minutes instead of todays date
that was my other PR

the WIP stuff is the database, i need to remove some UNIQUE constraints

@stonedDiscord stonedDiscord marked this pull request as draft April 13, 2020 13:35
@stonedDiscord stonedDiscord marked this pull request as ready for review April 28, 2020 19:49
@stonedDiscord stonedDiscord changed the title Past bans (WIP) Past bans Jul 12, 2020
@oldmud0
Copy link
Member

oldmud0 commented Jul 31, 2020

Will merge after 2.8 compatibility is finished and stable.

@stonedDiscord
Copy link
Member Author

bump

Copy link
Member

@oldmud0 oldmud0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues:

  • /baninfo won't retrieve a full ban history. Might need to add an index to ooc_events to speed up OOC name lookup.
  • Attaching an extra IPID/HDID to an existing ban using the /ban <ipid> <ban_id> syntax will not warn if that ban is no longer in force.

@stonedDiscord
Copy link
Member Author

i specifically don't want to use the unban date to invalidate a ban so you can keep track of who was banned for how long, even after they get unbanned by the moderators

i will work on the minor issues you listed soon

@stonedDiscord
Copy link
Member Author

since #161 also increments the DB version we should combine the migration scripts

stonedDiscord added a commit that referenced this pull request Feb 23, 2021
@stonedDiscord stonedDiscord merged commit c6b7bf1 into master Mar 1, 2021
@oldmud0
Copy link
Member

oldmud0 commented Mar 1, 2021

I'm fine with this as long as it was well tested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants