Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Unban log entry does not contain original information about the ban #52

Open
oldmud0 opened this issue Jul 20, 2019 · 1 comment
Open

Comments

@oldmud0
Copy link
Member

oldmud0 commented Jul 20, 2019

Since the ban entry is removed, the ban ID is useless, rendering the unban log entry useless, rendering it impossible to know any information about why someone was unbanned or why someone was banned in the first place.
The best way to resolve this issue is to add a column to the ban list for whether or not the ban record is in effect or not, then update all of the queries to only filter by ban records in effect.

(@oldmud0, https://gitlab.com/AttorneyOnline/tsuserver3/issues/51)

@stonedDiscord
Copy link
Member

#98

Crystalwarrior referenced this issue in Crystalwarrior/KFO-Server Feb 11, 2022
…while they were off. [#53] (#52)

* Fix /bg turning on lights in previously dark rooms.

* Update segment and internal versions.

* Update CHANGELOG.md.

* Fix /lights issue(this time for real).
Crystalwarrior referenced this issue in Crystalwarrior/KFO-Server Feb 11, 2022
* Fix bugs in /showname_freeze and /showname_nuke. (#37) (#38)

* Fix bugs in /showname_freeze and /showname_nuke.

* Update CHANGELOG.md

* Fix /bg turning lights on in previously dark areas. [#43](#44)

* Fix /bg turning on lights in previously dark rooms.

* Fix to pass test.py.

* Fix non-numerical music length tracks being allowed (#32)+Backport fixes in 037623f

* Fix #46+Readd /login to README.md

* Fix OS errors on loading area list or music list files not being properly caught (#51)

* Music lists that list no length for a track may be loaded again (are assumed to not loop)

* Fix /lights from keeping lights off if the background wasn't changed while they were off. [#53] (#52)

* Fix /bg turning on lights in previously dark rooms.

* Update segment and internal versions.

* Update CHANGELOG.md.

* Fix /lights issue(this time for real).

* 4.2.4 (#56)

* First commit for 4.2.4

* Start adding 4.3.0-dev features not related to main functions

All features come from RaveMaster073's contributions, namely
* cc340c6
* 7a58f00
* 70cb1d8
* 67456c5
* 12f927e
* 930367b
* ef0fcd0

* Finish adding 4.3.0-dev features not related to featured functions

All features come from RaveMaster073's contributions, namely
* c76cc82
* d458309

* Add /cid

* Add client IDs to login/logout/failed logins notifications

* Allow GMs to /make_gm their multiclients (and only their multiclients)

* Rewrite default daily passwords to properly reflect when they are valid

* Add /zone_lights. (#47)

* Add /zone_lights.

* Fix branch differences.

* Fix recommended changes.

* Fix recommended changes.

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Add /sa, /sas, /shout, /unsneak, /yell. (#48)

* Add /sa, /sas, /shout, /unsneak, /yell.

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Add best effort support for AO 2.7 clients. (#49)

* Add best effort support for AO 2.7 clients.

* Maintain 100 character limit for lines of code

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Forward-port 4.2.3-post9 changes in ea3f514

* Enforce Python 3.6+ requirement+Warn pending deprecation of Python 3.6.

* Forward-port 4.2.3-post10 changes in 054a88f

* Add parameter description for area list files

* Forward-port 4.2.3-post11 changes in 154c187

* Add OOC name, character/persona, and iniswaps to GM commands that only took client ID. (Unfinished)

* Add user ID support to commands.

* Revert changes on GM commands.

* Update CHANGELOG.md

* Include 4.2.3-post11 bugfix in changelog

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Update /time and /time12 to allow for custom UTC offset (first 4.2.4 beta)

* Add instructions to configuration files

* Properly reject webAO+Log abnormal connections+Fix DOS exploit

* Fix /toggle_allrolls outputing rolls from outside watched zone if roller was out of a zone

* Fix /multiclients failing if target was not staff and their area would not have been printed in /getareas

* Update (and fix!) README and Changelog for 4.2.4 (Release Candidate)

* Actually force port 0 for webAO+Undeprecate /showname_list+Fix Changelog

* 4.2.4 out

Co-authored-by: Toddler Howard <47868518+RaveMaster073@users.noreply.github.com>

* Fix no IC duplication management+Fix broken KFO compatiblity+Increase termination log size (#57)

* Fix no IC duplication management+Fix broken KFO compatiblity+Increase termination log

Remind me to be careful what branch I use next time.

* Fix turning lights on before party disbands raising TypeError [#58]

* Update broken tests+Other miscellaneous wrong merges

* Drop Python 3.6 support+Change some wording

* Update README with Python requirement+Remove deprecated commands from README

Co-authored-by: RaveMaster073 <47868518+RaveMaster073@users.noreply.github.com>
Crystalwarrior referenced this issue in Crystalwarrior/KFO-Server Feb 11, 2022
* Fix bugs in /showname_freeze and /showname_nuke. (#37) (#38)

* Fix bugs in /showname_freeze and /showname_nuke.

* Update CHANGELOG.md

* Fix /bg turning lights on in previously dark areas. [#43](#44)

* Fix /bg turning on lights in previously dark rooms.

* Fix to pass test.py.

* Fix non-numerical music length tracks being allowed (#32)+Backport fixes in 037623f

* Fix #46+Readd /login to README.md

* Fix OS errors on loading area list or music list files not being properly caught (#51)

* Music lists that list no length for a track may be loaded again (are assumed to not loop)

* Fix /lights from keeping lights off if the background wasn't changed while they were off. [#53] (#52)

* Fix /bg turning on lights in previously dark rooms.

* Update segment and internal versions.

* Update CHANGELOG.md.

* Fix /lights issue(this time for real).

* 4.2.4 (#56)

* First commit for 4.2.4

* Start adding 4.3.0-dev features not related to main functions

All features come from RaveMaster073's contributions, namely
* cc340c6
* 7a58f00
* 70cb1d8
* 67456c5
* 12f927e
* 930367b
* ef0fcd0

* Finish adding 4.3.0-dev features not related to featured functions

All features come from RaveMaster073's contributions, namely
* c76cc82
* d458309

* Add /cid

* Add client IDs to login/logout/failed logins notifications

* Allow GMs to /make_gm their multiclients (and only their multiclients)

* Rewrite default daily passwords to properly reflect when they are valid

* Add /zone_lights. (#47)

* Add /zone_lights.

* Fix branch differences.

* Fix recommended changes.

* Fix recommended changes.

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Add /sa, /sas, /shout, /unsneak, /yell. (#48)

* Add /sa, /sas, /shout, /unsneak, /yell.

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Add best effort support for AO 2.7 clients. (#49)

* Add best effort support for AO 2.7 clients.

* Maintain 100 character limit for lines of code

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Forward-port 4.2.3-post9 changes in ea3f514

* Enforce Python 3.6+ requirement+Warn pending deprecation of Python 3.6.

* Forward-port 4.2.3-post10 changes in 054a88f

* Add parameter description for area list files

* Forward-port 4.2.3-post11 changes in 154c187

* Add OOC name, character/persona, and iniswaps to GM commands that only took client ID. (Unfinished)

* Add user ID support to commands.

* Revert changes on GM commands.

* Update CHANGELOG.md

* Include 4.2.3-post11 bugfix in changelog

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Update /time and /time12 to allow for custom UTC offset (first 4.2.4 beta)

* Add instructions to configuration files

* Properly reject webAO+Log abnormal connections+Fix DOS exploit

* Fix /toggle_allrolls outputing rolls from outside watched zone if roller was out of a zone

* Fix /multiclients failing if target was not staff and their area would not have been printed in /getareas

* Update (and fix!) README and Changelog for 4.2.4 (Release Candidate)

* Actually force port 0 for webAO+Undeprecate /showname_list+Fix Changelog

* 4.2.4 out

Co-authored-by: Toddler Howard <47868518+RaveMaster073@users.noreply.github.com>

* Fix no IC duplication management+Fix broken KFO compatiblity+Increase termination log size (#57)

* Fix no IC duplication management+Fix broken KFO compatiblity+Increase termination log

Remind me to be careful what branch I use next time.

* Fix turning lights on before party disbands raising TypeError [#58]

* 4.2.4-post3 (#63)

* OOC warn clients whose version cannot be recognized

* Support Case Cafe clients with Update 22 or higher

* Handle different MC packet protocols

* Allow 2.8 pairs+2.6 pairs

* Allow background with position packets for AO 2.8

* Improve error messages for missing config folder+invalid characters/areas+localhost joining

* Assume theoretical CC24 client uses AO 2.8 protocol

* Make /charselect send output messages

* Fix broken toggle_allpasses doc+Add doc for /gmlock and pending deprecation message

* Improve client termination messages+Add missing one for packet too short

* Update changelog and bump version

* Remove leftover code+Add deprecation warning to /gmlock

* Added fact that unrecognized clients are now warned in OOC when they join

* Make 'MC' packet send showname rather than displayname+Implement new DRO MC protocol

* Remove merge artifact

Co-authored-by: RaveMaster073 <47868518+RaveMaster073@users.noreply.github.com>
Crystalwarrior referenced this issue in Crystalwarrior/KFO-Server Feb 11, 2022
* Fix bugs in /showname_freeze and /showname_nuke. (#37) (#38)

* Fix bugs in /showname_freeze and /showname_nuke.

* Update CHANGELOG.md

* Fix /bg turning lights on in previously dark areas. [#43](#44)

* Fix /bg turning on lights in previously dark rooms.

* Fix to pass test.py.

* Fix non-numerical music length tracks being allowed (#32)+Backport fixes in 037623f

* Fix #46+Readd /login to README.md

* Fix OS errors on loading area list or music list files not being properly caught (#51)

* Music lists that list no length for a track may be loaded again (are assumed to not loop)

* Fix /lights from keeping lights off if the background wasn't changed while they were off. [#53] (#52)

* Fix /bg turning on lights in previously dark rooms.

* Update segment and internal versions.

* Update CHANGELOG.md.

* Fix /lights issue(this time for real).

* 4.2.4 (#56)

* First commit for 4.2.4

* Start adding 4.3.0-dev features not related to main functions

All features come from RaveMaster073's contributions, namely
* cc340c6
* 7a58f00
* 70cb1d8
* 67456c5
* 12f927e
* 930367b
* ef0fcd0

* Finish adding 4.3.0-dev features not related to featured functions

All features come from RaveMaster073's contributions, namely
* c76cc82
* d458309

* Add /cid

* Add client IDs to login/logout/failed logins notifications

* Allow GMs to /make_gm their multiclients (and only their multiclients)

* Rewrite default daily passwords to properly reflect when they are valid

* Add /zone_lights. (#47)

* Add /zone_lights.

* Fix branch differences.

* Fix recommended changes.

* Fix recommended changes.

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Add /sa, /sas, /shout, /unsneak, /yell. (#48)

* Add /sa, /sas, /shout, /unsneak, /yell.

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Add best effort support for AO 2.7 clients. (#49)

* Add best effort support for AO 2.7 clients.

* Maintain 100 character limit for lines of code

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Forward-port 4.2.3-post9 changes in ea3f514

* Enforce Python 3.6+ requirement+Warn pending deprecation of Python 3.6.

* Forward-port 4.2.3-post10 changes in 054a88f

* Add parameter description for area list files

* Forward-port 4.2.3-post11 changes in 154c187

* Add OOC name, character/persona, and iniswaps to GM commands that only took client ID. (Unfinished)

* Add user ID support to commands.

* Revert changes on GM commands.

* Update CHANGELOG.md

* Include 4.2.3-post11 bugfix in changelog

Co-authored-by: Chrezm <TheChrezm@gmail.com>

* Update /time and /time12 to allow for custom UTC offset (first 4.2.4 beta)

* Add instructions to configuration files

* Properly reject webAO+Log abnormal connections+Fix DOS exploit

* Fix /toggle_allrolls outputing rolls from outside watched zone if roller was out of a zone

* Fix /multiclients failing if target was not staff and their area would not have been printed in /getareas

* Update (and fix!) README and Changelog for 4.2.4 (Release Candidate)

* Actually force port 0 for webAO+Undeprecate /showname_list+Fix Changelog

* 4.2.4 out

Co-authored-by: Toddler Howard <47868518+RaveMaster073@users.noreply.github.com>

* Fix no IC duplication management+Fix broken KFO compatiblity+Increase termination log size (#57)

* Fix no IC duplication management+Fix broken KFO compatiblity+Increase termination log

Remind me to be careful what branch I use next time.

* Fix turning lights on before party disbands raising TypeError [#58]

* 4.2.4-post3 (#63)

* OOC warn clients whose version cannot be recognized

* Support Case Cafe clients with Update 22 or higher

* Handle different MC packet protocols

* Allow 2.8 pairs+2.6 pairs

* Allow background with position packets for AO 2.8

* Improve error messages for missing config folder+invalid characters/areas+localhost joining

* Assume theoretical CC24 client uses AO 2.8 protocol

* Make /charselect send output messages

* Fix broken toggle_allpasses doc+Add doc for /gmlock and pending deprecation message

* Improve client termination messages+Add missing one for packet too short

* Update changelog and bump version

* Remove leftover code+Add deprecation warning to /gmlock

* Added fact that unrecognized clients are now warned in OOC when they join

* Fix servers not launching if they do not set some daily passwords. (#66) (#67)

* Check for password existence first, perform appropriate actions depending on type

* Remove server.config['passwords'] in favor of making it an internal server attribute

* Update documentation and bump version

* Fix improper clearing of paused clocks of disconnected players. (#68) (#69)

* Catch KeyError due to clock cancelation after a pause

* Remove leftover just_paused and properly cancel tasks from disconnecting players

* 4.2.5 (#76)

* Do not abort server launch if failing to obtain public IP (#70)

* Fix AO 2.8 not loading the music list properly

* Set working directory to start_server.py directory+Make all crashes require Enter input to exit (#71)

* GlobalIC prefix workaround, remove for 4.3

* Raised character limit to 1024 except for IC-commands (these remain at 256)

* Screams now display the scream in IC to the screamer

* Update README and bump up internal version to 4.2.5

* zone_play and zone_lights now send status messages to sender and zone watchers

* Dname and ID (#73)

* More dname and id

* More work

* Final ones

* Bump up version number

* Give /play and /rplay additional status messages

* Warn if track name for /play, /rplay and /zone_play is not recognized

* Forgot to fix /zone_play test

* Party whisper (#74)

* Basic /party_whisper (alias /pw and /huddle)

* Update README and changelog

* Update char list (#75)

* Move refresh char list code to separate method

* Start rewriting for future update (cannot be done with current client)

* Add /zone_info

* Update README with 4.2.5 nomenclature (bump to beta 1)

* Add /logingm as an alias to /loginrp

* Have /party_members and /zone_info list client IDs

* 4.2.5 out

* 4.2.5-post1 (#77) (#78)

* whois command now shows global IC and global IC prefix statuses

* Fix global IC areas and prefix not reseting on area list reload

* Cancel clock and remove global IC areas and prefixes if needed on /logout

* /logout and /cleargm cancel global IC, clocks and permission to use restricted characters

* Bump up version number

* 4.2.5-post2: Make /logingm filter out server passwords (#79) (#80)

* 4.2.5-post3: Fix /scream not showing default or custom shownames in IC (#81) (#82)

* Fix /scream not showing default or custom shownames in IC

* Standardize /scream for deaf players

* Missing bracket

* Remove merge artifacts

Co-authored-by: RaveMaster073 <47868518+RaveMaster073@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants