Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github issue instead of #warning directives in api_tests.cpp #260

Closed
linh2931 opened this issue Sep 29, 2022 · 1 comment · Fixed by #607
Closed

Use github issue instead of #warning directives in api_tests.cpp #260

linh2931 opened this issue Sep 29, 2022 · 1 comment · Fixed by #607
Assignees
Labels
actionable 👍 lgtm OCI Work exclusive to OCI team

Comments

@linh2931
Copy link
Member

api_tests.cpp has 3 #warning directives

#warning TODO validate that the contract was successfully cached

#warning TODO validate that the contract was successfully cached

Those directives have been there since 06/07/2018.

Remove the directives and create this issue so it can be triaged

@heifner
Copy link
Member

heifner commented Oct 18, 2022

Could add a getter for cache size to wasm_interface, controller already has a get_wasm_interface(). The test could then check size of the cache before and after.

@heifner heifner added actionable and removed triage labels Oct 18, 2022
@heifner heifner self-assigned this Dec 28, 2022
@heifner heifner added the OCI Work exclusive to OCI team label Dec 28, 2022
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 28, 2022
heifner added a commit that referenced this issue Jan 5, 2023
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jan 5, 2023
heifner added a commit that referenced this issue Jan 9, 2023
Tests: Add is_code_cached and use in tests to verify
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants