[3.2] more compiler warnings cleanup #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolve #254
After this PR, only 4 warnings remain in submodules
abieos
andlibfc/libraries/ff/libff
.Most of the changes are straightforward. The following two need to be noted.
wasm_tests.cpp
andapi_tests.cpp
, I created issues for them Use github issue instead of #warning directive in wasm_tests.cpp #259 and Use github issue instead of #warning directives in api_tests.cpp #260. I think this is a better way to handle TODOs. Leaving them in #warning will not get them to be done. I kept them as comments for easier identification if we decide to work on them.chain_plugin.cpp
, I need to introduce a new macroFC_LOG_AND_DROP_NO_INTERPROCESS_BAD_ALLOC
. The warning was