Tests: Add is_code_cached and use in tests to verify #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadh
pushed a commit
to cmadh/leap
that referenced
this pull request
Jan 2, 2023
…-head-of-abieos [3.2] mandel: rebase abieos to the head of abieos submodule (fixing compile warnings)
spoonincode
reviewed
Jan 4, 2023
| @@ -63,6 +63,9 @@ namespace eosio { namespace chain { | |||
| //Immediately exits currently running wasm. UB is called when no wasm running | |||
| void exit(); | |||
|
|
|||
| //Returns true if the code is cached | |||
| size_t is_code_cached(const digest_type& code_hash, const uint8_t& vm_type, const uint8_t& vm_version) const; | |||
There was a problem hiding this comment.
I think you meant for the return value to be bool?
spoonincode
reviewed
Jan 5, 2023
| bool base_tester::is_code_cached( eosio::chain::account_name name ) const { | ||
| const auto& db = control->db(); | ||
| const account_metadata_object* receiver_account = &db.template get<account_metadata_object,by_name>( name ); | ||
| if ( receiver_account->code_hash == digest_type() ) return false; |
There was a problem hiding this comment.
Do we need to check receiver_account != nullptr first? If the account doesn't exist
There was a problem hiding this comment.
get() throws unknown key if not found.
There was a problem hiding this comment.
oops yeah I was looking at find()
spoonincode
approved these changes
Jan 5, 2023
greg7mdp
approved these changes
Jan 9, 2023
greg7mdp
reviewed
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
is_code_cachedmethod towasm_interfacefor use by tests to check if the code for a given account has been cached.Resolves #260