#1805: Disables editing the SharedBuffer when in readonly mode, #1827
Conversation
Disables Retab modifying the buffer in readonly mode
| toSpaces := b.Settings["tabstospaces"].(bool) | ||
| tabsize := util.IntOpt(b.Settings["tabsize"]) | ||
| dirty := false | ||
| if !b.Type.Readonly { |
There was a problem hiding this comment.
This may be good as a temporary fix. But there is one more issue with Retab: it is not undoable. The reason is that if modifies the buffer directly, not via EventHandler, i.e. bypasses the undo stack. So it seems a final solution would be to change Retab to use EventHandler's Replace or MultipleReplace, and add readonly mode check for any replace operations.
| b.isModified = true | ||
| b.HasSuggestions = false | ||
| b.LineArray.insert(pos, value) | ||
| if !b.Type.Readonly { |
There was a problem hiding this comment.
AFAICS the only reason for this is that MoveLinesUp calls this low-level insert function directly (which also, like in case with retab, causes another issue: undo doesn't work correctly for MoveLinesUp at the last line).
It was changed to use insert instead of Insert in the commit cfc595e. I wonder what was the reason for that.
Disables Retab modifying the buffer in readonly mode
Fixes: #1805