Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly mode doesn't disallow undo, replace, retab... #1805

Open
dmaluka opened this issue Aug 2, 2020 · 0 comments
Open

Readonly mode doesn't disallow undo, replace, retab... #1805

dmaluka opened this issue Aug 2, 2020 · 0 comments
Labels
major

Comments

@dmaluka
Copy link
Collaborator

dmaluka commented Aug 2, 2020

Description of the problem or steps to reproduce

Read-only mode (enabled via readonly option) doesn't fully disallow editing the buffer. It disables inserting and deleting text but doesn't disable at least the following operations:

  • undo/redo
  • replace
  • retab
  • comment/uncomment via comment plugin (since it uses Replace internally)

Specifications

Commit hash: ce46b8e
OS: any
Terminal: any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1805: Disables editing the SharedBuffer when in readonly mode, kylejwatson/micro
1 participant
@dmaluka