notif: Parse notification messages, on Android #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of this is based on the Kotlin code that does this same job in the zulip-mobile RN app: android/app/src/main/java/com/zulipmobile/notifications/FcmMessage.kt android/app/src/test/java/com/zulipmobile/notifications/FcmMessageTest.kt Those Kotlin tests benefit from a feature of their test framework where when an expectation like `expect.that(foo).isEqualTo(bar)` (analogous to our `check(foo).equals(bar)`) is unsatisfied, it records the failure without immediately ending the test function. As a result, when something goes wrong we get very fine-grained results, much like we would with package:checks if all the test functions were translated as `group` and the individual expectations as `test`, rather than as `check` -- but without the overhead that the latter approach requires in the source code, particularly in making up names for the individual test cases. In this version, we go ahead and translate to `group` and `test` for a couple of the test functions where their lack would be most keenly felt, resorting to a hack to avoid cluttering the code with lots of individual names. We let the rest be just `test` and `check`.
The first version of this test file included these for ease of comparison with zulip-mobile's FcmMessageTest.kt; but they don't really add anything over the more detailed test cases that follow.
In zulip-mobile we use this to identify the conversation in the case of a 1:1 DM thread, as a legacy of senderId having not always been present. Here we'll use the numeric ID from the start.
c0a4aa9 to
7a3f13d
Compare
|
LGTM, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked atop #325, and makes the next step toward #320/#122.