Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notifications on Android #320

Closed
gnprice opened this issue Oct 16, 2023 · 0 comments · Fixed by #352
Closed

Show notifications on Android #320

gnprice opened this issue Oct 16, 2023 · 0 comments · Fixed by #352
Assignees
@gnprice
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications
Milestone
M0: Alpha

Comments

@gnprice
Copy link
Member

gnprice commented Oct 16, 2023

Part of #122.

I have a draft branch already that does this.
@gnprice gnprice added a-Android Issues specific to Android, or requiring Android-specific work a-notifications labels Oct 16, 2023
@gnprice gnprice added this to the Alpha milestone Oct 16, 2023
@gnprice gnprice self-assigned this Oct 16, 2023
@gnprice gnprice mentioned this issue Oct 16, 2023
Closed
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Oct 17, 2023
@gnprice
notif: Get token on Android, and send to server
86f8e36 
This implements part of zulip#320.

To make an end-to-end demo, we also listen for notification
messages, and just print them to the debug log.
@gnprice gnprice mentioned this issue Oct 17, 2023
Merged
@gnprice gnprice mentioned this issue Oct 24, 2023
Merged
chrisbobbe pushed a commit to gnprice/zulip-flutter that referenced this issue Oct 25, 2023
@gnprice @chrisbobbe
notif: Get token on Android, and send to server
11d456d 
This implements part of zulip#320.

To make an end-to-end demo, we also listen for notification
messages, and just print them to the debug log.
This was referenced Oct 26, 2023
Closed
Closed
Closed
Merged
gnprice added a commit that referenced this issue Oct 31, 2023
@gnprice
notif: Show notifications! on Android, in foreground
b6badf5 
This implements most of the remaining work of #320.

It doesn't yet deliver most of the user-facing value: for that, the
remaining piece will be to make notifications appear when the app is
in the background as well as when it's in the foreground.  I have a
draft for that and it works, but the tests require some more fiddling
which I may not get to today, so I wanted to get the bulk of this
posted for review.

Many other improvements still to be made are tracked as their own
issues: most notably iOS support #321, and opening a conversation
by tapping the notification #123.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 1, 2023
@gnprice
notif: Handle when app in background, too (on Android)
73bb87b 
This completes the core functionality of showing notifications on
Android, zulip#320.

Sadly this does not work very well if the app isn't running at all:
e.g., if you terminate the app by swiping it away in the app switcher.
In that case the notification can be quite a bit delayed.

But fixing that seems likely to require some deeper debugging, and
getting our hands into Java or Kotlin code for I think the first time
in zulip-flutter.  So we'll deal with that as a followup issue, zulip#342.
Details there.

Fixes: zulip#320
@gnprice gnprice mentioned this issue Nov 1, 2023
Merged
@gnprice gnprice closed this as completed in 9be01bd Nov 1, 2023
@gnprice gnprice mentioned this issue Nov 21, 2023
Closed
@gnprice gnprice mentioned this issue Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications
Projects
Flutter app
Status: Done
Milestone
M0: Alpha
Development

Successfully merging a pull request may close this issue.

notif: Handle when app in background, too (on Android) gnprice/zulip-flutter
1 participant
@gnprice