-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI: Implement inbox design for empty state #1294
base: main
Are you sure you want to change the base?
Update UI: Implement inbox design for empty state #1294
Conversation
Closing #1293 as promised. |
Thanks for PR. Before we can review in detail, this needs:
If you need help with Git, |
In your commit and PR description (two places), please also say |
Could you please check this for me? Thank you! |
Is the font in the second line bigger? They look the same to me in Figma. |
Let's make it "inbox" rather than "Inbox", for consistency with Zulip's capitalization style. |
Please also add light-theme screenshot to the PR description. |
I'm not sure we've got a good call to action in the second line; I'll post on the CZO thread. |
Yes, we have the Inbox in Figma. However if you still want that then tell me thanks ! |
In this FIGMA have only one disine for light or dark them |
Yep, that's why I said it. ;) |
Well, regardless of that, the app will need to work in both light theme and dark theme. You can make a good guess for what it should look like, and ask about anything where you're uncertain. |
Also, the Figma does have a dark-theme design: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5967-180775&m=dev |
Yes, I see that the colors and designs are the same. If you would like any modifications, please let me know what you have in mind, and I'd be happy to make those changes for you. |
I still need to see screenshots of your changes in both themes in the PR description. |
I updated that pls check can you tell me what font family we use in this |
Thanks. The font size still looks off. |
For questions like this, it's your responsibility to find the answer in the Figma design. Please don't ask us to spend our time answering questions that already have clear answers. |
This pull request (PR) addresses issue #386 and enhances the user interface by introducing a conditional feature for displaying messages.
If messages are available, they are displayed in the UI. If no messages exist, a default text is shown instead. This improvement enhances the user experience by providing clear feedback when no messages are present.
Changes Made:
Testing:
Figma link:-
The updated UI aligns with the Figma design provided here
[Figma Design Link]
(https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5966-176642&p=f&t=gdUmGEmNiTNiCHVf-0)
Ensured consistent behaviour across various screen sizes and edge cases.
Screenshots:
Old image:
New image:
Light them