Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI: Implement inbox design for empty state #1294

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yashrajpu
Copy link

@yashrajpu yashrajpu commented Jan 20, 2025

This pull request (PR) addresses issue #386 and enhances the user interface by introducing a conditional feature for displaying messages.

If messages are available, they are displayed in the UI. If no messages exist, a default text is shown instead. This improvement enhances the user experience by providing clear feedback when no messages are present.

Changes Made:

  • Implemented logic to check for the existence of messages.
  • Displayed messages when available; if not, switched to a default text.
  • Improved the overall layout and clarity of the UI.

Testing:

  • Verified that the feature works correctly when messages are present.
  • Confirmed the fallback text appears appropriately when no messages are available.

Figma link:-

The updated UI aligns with the Figma design provided here

[Figma Design Link]
(https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5966-176642&p=f&t=gdUmGEmNiTNiCHVf-0)

Ensured consistent behaviour across various screen sizes and edge cases.

Screenshots:

Old image:

Screenshot 2025-01-21 at 9 42 19 AM

New image:

Screenshot 2025-01-21 at 9 42 54 AM

Light them

Screenshot 2025-01-23 at 1 21 04 PM

@apoorvapendse
Copy link
Contributor

@apoorvapendse
Copy link
Contributor

Closing #1293 as promised.

@chrisbobbe
Copy link
Collaborator

Thanks for PR. Before we can review in detail, this needs:

If you need help with Git, #git help in the development community is the best place to ask.

@chrisbobbe
Copy link
Collaborator

In your commit and PR description (two places), please also say Fixes #1294..

@yashrajpu
Copy link
Author

Could you please check this for me? Thank you!

@alya
Copy link
Collaborator

alya commented Jan 22, 2025

Is the font in the second line bigger? They look the same to me in Figma.

@alya
Copy link
Collaborator

alya commented Jan 22, 2025

Let's make it "inbox" rather than "Inbox", for consistency with Zulip's capitalization style.

@alya
Copy link
Collaborator

alya commented Jan 22, 2025

Please also add light-theme screenshot to the PR description.

@alya
Copy link
Collaborator

alya commented Jan 22, 2025

I'm not sure we've got a good call to action in the second line; I'll post on the CZO thread.

@yashrajpu
Copy link
Author

Let's make it "inbox" rather than "Inbox", for consistency with Zulip's capitalization style.

Yes, we have the Inbox in Figma. However if you still want that then tell me thanks !

@yashrajpu
Copy link
Author

Please also add light-theme screenshot to the PR description.

In this FIGMA have only one disine for light or dark them

@alya
Copy link
Collaborator

alya commented Jan 22, 2025

However if you still want that then tell me thanks !

Yep, that's why I said it. ;)

@alya
Copy link
Collaborator

alya commented Jan 22, 2025

In this FIGMA have only one disine for light or dark them

Well, regardless of that, the app will need to work in both light theme and dark theme. You can make a good guess for what it should look like, and ask about anything where you're uncertain.

@chrisbobbe
Copy link
Collaborator

Also, the Figma does have a dark-theme design: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5967-180775&m=dev

image

@yashrajpu
Copy link
Author

Yes, I see that the colors and designs are the same. If you would like any modifications, please let me know what you have in mind, and I'd be happy to make those changes for you.

@alya
Copy link
Collaborator

alya commented Jan 23, 2025

I still need to see screenshots of your changes in both themes in the PR description.

@yashrajpu
Copy link
Author

I still need to see screenshots of your changes in both themes in the PR description.

I updated that pls check can you tell me what font family we use in this

@alya
Copy link
Collaborator

alya commented Jan 23, 2025

Thanks. The font size still looks off.

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jan 23, 2025

[…] can you tell me what font family we use in this

For questions like this, it's your responsibility to find the answer in the Figma design. Please don't ask us to spend our time answering questions that already have clear answers.

@yashrajpu
Copy link
Author

Screenshot 2025-01-24 at 12 35 25 PM Screenshot 2025-01-24 at 12 40 32 PM

Thanks. The font size still looks off.
I fixed that .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants