autocomplete test: Add extra pump in new test for new RawAutocomplete delay #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can wait for Greg's review to merge this; tagging Zixuan for review so you're aware I've debugged the CI failure and in case I've got some reasoning wrong. 🙂 I know Greg is OOO today, and Monday is a holiday. And although there is a PR to re-enable Zulip in Flutter's customer tests registry—flutter/tests#441 —it shouldn't block any Flutter PRs if it gets merged. That's because the Zulip commit in that PR: + fetch=git -C tests checkout 0bfa79d23fc9fcf5ce0cc5a21540434f526838d9comes before the commit that adds the currently-failing test. |
This was referenced Jan 17, 2025
This was referenced Jan 18, 2025
|
Oops, thanks for the fix. Looks good — merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1289.