Skip to content

Commit

Permalink
build: pin ninja pip version temporarily to resolve build failure (ll…
Browse files Browse the repository at this point in the history
…vm#1558)

Going from ninja v1.10.2 to v1.11.1, there is a change that breaks the
CI builds with the following error:

```
CMake Error at CMakeLists.txt:47 (project):
  Running
   '/main_checkout/torch-mlir/docker_venv/bin/ninja' '--version'
  failed with:
CMake Error: CMAKE_ASM_COMPILER not set, after EnableLanguage
```

Ostensibly, the reason for the error about the ASM compiler is because
llvm-project/llvm/CMakeLists.txt includes ASM among the list of
languages used in the LLVM project. Adding `-DCMAKE_ASM_COMPILER=clang`
does not resolve the error.

Until we figure out why the new version of ninja causes the build
failures, this patch pins the ninja to the one that worked.
  • Loading branch information
ashay authored Nov 5, 2022
1 parent 5ee20e7 commit 27d8d47
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pybind11
wheel
setuptools
cmake
ninja
ninja==1.10.2

# Workaround for what should be a torch dep
# See discussion in #1174
Expand Down

0 comments on commit 27d8d47

Please sign in to comment.