build: pin ninja pip version temporarily to resolve build failure #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going from ninja v1.10.2 to v1.11.1, there is a change that breaks the CI builds with the following error: ``` CMake Error at CMakeLists.txt:47 (project): Running '/main_checkout/torch-mlir/docker_venv/bin/ninja' '--version' failed with: CMake Error: CMAKE_ASM_COMPILER not set, after EnableLanguage ``` Ostensibly, the reason for the error about the ASM compiler is because llvm-project/llvm/CMakeLists.txt includes ASM among the list of languages used in the LLVM project. Adding `-DCMAKE_ASM_COMPILER=clang` does not resolve the error. Until we figure out why the new version of ninja causes the build failures, this patch pins the ninja to the one that worked.
vivekkhandelwal1
approved these changes
Nov 5, 2022
|
I am not sure this would fix it but worth the try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from ninja v1.10.2 to v1.11.1, there is a change that breaks
the CI builds with the following error:
Ostensibly, the reason for the error about the ASM compiler is because
llvm-project/llvm/CMakeLists.txt includes ASM among the list of
languages used in the LLVM project. Adding
-DCMAKE_ASM_COMPILER=clangdoes not resolve the error.
Until we figure out why the new version of ninja causes the build
failures, this patch pins the ninja to the one that worked.