Enter room if active_room query parameter is passed in #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user512
commented
Aug 2, 2020
| } | ||
|
|
||
| activeRoomName() { | ||
| const urlParams = new URLSearchParams(window.location.search); |
There was a problem hiding this comment.
Doesn't work with IE, need a polyfill?
https://caniuse.com/#feat=urlsearchparams
zspencer
requested changes
Aug 2, 2020
There was a problem hiding this comment.
I think this is a good start, but the thing I worry about is we're going "off the rails" so to speak when it comes to routing; which means we're starting to build our own routing layer in Stimulus.
I think I'd rather we leveraged rails built-in routing and create a RoomsController#show action and corresponding views so that we don't have to rely on pushState and other JavaScript to figure out where we want to go or why.
We can then lean into TurboLinks or a similar pjax tool to make the pages load quickly and relatively painlessly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects: #59
Example:
When user enter the below url, app will enter room ada
http://convene.zinc.coop/workspaces/zinc?active_room=ada