Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering Rooms #59

Closed
8 tasks done
zspencer opened this issue Jul 31, 2020 · 4 comments
Closed
8 tasks done

Entering Rooms #59

zspencer opened this issue Jul 31, 2020 · 4 comments
Assignees
@zspencer
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits

Comments

@zspencer
Copy link
Member

zspencer commented Jul 31, 2020 •
edited
Loading

This Issue May Be Closed When

  • Move feature definition into repo
  • Wire in stepsf or non-branded domain scenarios
  • Entering Rooms via Slug in a Branded Domain
  • Entering Rooms via Full URL
  • Entering Rooms via Room Picker on Dashboard
  • Entering Rooms via Room Picker while in a Room
  • There are Release Notes under the 1.0 describing the first version of this feature in CHANGELOG.md
  • There is marketing copy describing this unique value proposition on the www.zinc.coop/convene landing page

Feature Definition

Feature: Entering Rooms
  In order to interact with people
  I want to enter a room

Scenario: Entering Room via Slug on a Branded Domain
  Given a Workspace with a Branded Domain
  When I visit a Room's using a slug on their Branded Domain
  Then I have entered the Room 

Scenario: Entering Unlocked Room via Room full URL
  When I visit a Room's full URL
  Then I have entered the Room 

Scenario: Entering Room via Room Picker on Workspace Dashboard
  Given I am on a Workspace Dashboard
  When I tap the Room in the Room Picker
  Then I have entered the Room 

Scenario: Entering Room via Room Picker on another Room 
  Given I am in a Room
  When I tap a different Room in the Room Picker
  Then I have entered the different Room 

Scenario: Entering Unlisted Room via Room full URL
  When I visit an Unlisted Room's Full URL
  Then I have entered the Room
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits ⛰️ epic Work we expect will take multiple patches to complete labels Jul 31, 2020
@zspencer zspencer added this to the 1.0 - Andromeda milestone Jul 31, 2020
@user512 user512 self-assigned this Aug 2, 2020
This was referenced Aug 2, 2020
Closed
Merged
@zspencer
Copy link
Member Author

zspencer commented Aug 7, 2020

@user512 - I noticed that even if we know the rooms full URL, we can't access unlisted rooms. I created a scenario illustrating the behavior that should happen:

Scenario: Entering Unlisted Room via Room full URL
  When I visit an Unlisted Room's Full URL
  Then I have entered the Room

I'll work on getting the feature steps actually wired in this weekend.

@user512
Copy link
Contributor

user512 commented Aug 7, 2020

Great, I originally thought it's supposed to not able to access unlisted room.

@zspencer
Copy link
Member Author

zspencer commented Aug 7, 2020

Yea, I wonder if what I actually want is a features/unlisted-rooms.feature file that describes what interactions people can have with unlisted rooms, similar to how we have features/locking-rooms.feature that describes what interactions are valid for locked rooms.

zspencer added a commit that referenced this issue Aug 11, 2020
@zspencer
Document how Entering Rooms works
0145a75 
See: #59

I've added the `@built` tag to indicate which features have been
_built_, so that it's a bit easier for someone who wants to start doing
some test automation to figure out what feature files need more work.
@zspencer zspencer mentioned this issue Aug 11, 2020
Merged
user512 pushed a commit that referenced this issue Aug 11, 2020
@zspencer
Document how Entering Rooms works (#78)
f88f430 
See: #59

I've added the `@built` tag to indicate which features have been
_built_, so that it's a bit easier for someone who wants to start doing
some test automation to figure out what feature files need more work.
zspencer pushed a commit that referenced this issue Aug 11, 2020
@user512
Room Owners may Discover their Unlisted Rooms (#79)
75482cd 
See: #72

- This also ensures that unlisted rooms can be entered by anyone who knows their URL. 
   See #59
@zspencer zspencer added the test label Aug 11, 2020
@zspencer zspencer mentioned this issue Aug 11, 2020
Closed
zspencer pushed a commit that referenced this issue Aug 17, 2020
@user512
Automate system test for entering and switching between rooms (#92)
608658e 
See: #59

Room slugs are also unique by workspace, not globally.

System Test and System Test Branded Domain workspaces have the same slug
for their room names; however this would fail without scoping the slug to the room.

Further, giving rooms a slug unique-to-workspace meant that we must tell Jitsi which
particular room we want someone to enter.
@zspencer zspencer assigned zspencer and unassigned user512 Aug 17, 2020
This was referenced Aug 20, 2020
Merged
Merged
@zspencer
Copy link
Member Author

Now that we have tests in place and copy in the changelog, I'm going to say this is good to go! wooo!

@zspencer zspencer added ⛰️ epic Work we expect will take multiple patches to complete and removed documentation ⛰️ epic Work we expect will take multiple patches to complete labels Aug 24, 2020
@zspencer zspencer mentioned this issue Nov 15, 2020
Closed
3 tasks
zspencer added a commit that referenced this issue Dec 5, 2020
@zspencer
Consolidate access permissions into one scenario
9305d15 
See:
- #41
- #40
- #59

We realized that the access permissions bits were a bit hard to track
down because they were spread across the entering rooms and locked rooms
feature definitions.

Because we assume people will be asking "who can enter this room?" it
made sense to consolidate the different permutations into a single
scenario in the Entering Rooms feature definition.
@zspencer zspencer mentioned this issue Jan 10, 2021
Closed
@zspencer zspencer removed this from the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zspencer zspencer

Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zspencer @user512