-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Marketplace
: Buying Products
: Saving Delivery Details
on Checkout
when no Cart Delivery Area
is set
#1983
Comments
Marketplace
: Buying Products
: Saving Delivery Details
on Checkout
when no Cart Delivery Area
is set
- #1983 Prevents `Shoppers` from visiting the `Checkout` screen until a `DeliveryArea` has been selected.
OK, I think I've got this fixed, as it's no longer possible to get to the Checkout screen until a Also, #1962 was getting in the way as well; because we would clear the set delivery area every time the page was loaded. oof. @anaulin want to re-test and tell me yay or nay? Or do you feel comfortable with my testing? |
@zspencer now I can't get the "Checkout" button to work at all in production: Kapture.2023-12-04.at.18.55.32.mp4 |
You have no products; so you can't check out. But we should probably make that clearer... |
@zspencer if you watch the video you'll see that i have products in my Cafe Gabriela cart |
After some more testing, I see that if I go to a vendor where I didn't already have a cart, and I select a delivery area, and also add something to my cart, then when I click the "Checkout" button it takes me to the next step. I think there are at least two issues:
|
- #1326 - #1983 (comment) It feels odd that we have a `Checkout` button when you can't click it.
Oh dang, I saw the first one and the last one but didn't realize Cafe Gabriela had the issue too. It is odd for the Cafe Gabriela; I think it's likely that there are some I've got a PR that removes the Checkout button completely as a kind of "stop-gap" because I didn't want to think about how to present a disabled Checkout button: #1999 |
#1999) - #1326 - #1983 (comment) It feels odd that we have a `Checkout` button when you can't click it.
I've purged the other |
Does seem to work now! (There is a separate bug about the delivery area saving not updating the cart, not sure if we have a separate issue to track that.) |
I've created an issue #2002 |
Marketplace
: Buying 🥡Products
#1326When a
Cart
does not have aDeliveryArea
, you can stillCheckout
.However, the
Checkout
screen does not have a way to set theDeliveryArea
, and if you try to set yourDeliveryAddress
it fails to save.The text was updated successfully, but these errors were encountered: