Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Marketplace: Buying Products: Saving Delivery Details on Checkout when no Cart Delivery Area is set #1983

Closed
Tracked by #1326 ...
anaulin opened this issue Nov 30, 2023 · 9 comments
Labels
🐞 bug Something isn't working

Comments

@anaulin
Copy link
Member

anaulin commented Nov 30, 2023

When a Cart does not have a DeliveryArea, you can still Checkout.

However, the Checkout screen does not have a way to set the DeliveryArea, and if you try to set your DeliveryAddress it fails to save.

@anaulin anaulin added this to the 1.0 - Andromeda milestone Nov 30, 2023
@zspencer zspencer added the 🐞 bug Something isn't working label Dec 1, 2023
@zspencer zspencer changed the title 🐞 Marketplace: checkout form fails silently to save when no delivery area is selected 🐞 Marketplace: Buying Products: Saving Delivery Details on Checkout when no Cart Delivery Area is set Dec 1, 2023
zspencer added a commit that referenced this issue Dec 4, 2023
- #1983

Prevents `Shoppers` from visiting the `Checkout` screen until a
`DeliveryArea` has been selected.
zspencer added a commit that referenced this issue Dec 4, 2023
…ea` (#1991)

`Marketplace`: `Checkout` is prevented without a `DeliveryArea`

- #1983

Prevents `Shoppers` from visiting the `Checkout` screen until a
`DeliveryArea` has been selected.
@zspencer
Copy link
Member

zspencer commented Dec 4, 2023

OK, I think I've got this fixed, as it's no longer possible to get to the Checkout screen until a DeliveryArea is set.

Also, #1962 was getting in the way as well; because we would clear the set delivery area every time the page was loaded. oof.

@anaulin want to re-test and tell me yay or nay? Or do you feel comfortable with my testing?

@anaulin
Copy link
Member Author

anaulin commented Dec 5, 2023

@zspencer now I can't get the "Checkout" button to work at all in production:

Kapture.2023-12-04.at.18.55.32.mp4

@zspencer
Copy link
Member

zspencer commented Dec 5, 2023

You have no products; so you can't check out. But we should probably make that clearer...

@anaulin
Copy link
Member Author

anaulin commented Dec 5, 2023

@zspencer if you watch the video you'll see that i have products in my Cafe Gabriela cart and my Crumble carts

@anaulin
Copy link
Member Author

anaulin commented Dec 5, 2023

After some more testing, I see that if I go to a vendor where I didn't already have a cart, and I select a delivery area, and also add something to my cart, then when I click the "Checkout" button it takes me to the next step.

I think there are at least two issues:

zspencer added a commit that referenced this issue Dec 5, 2023
- #1326
- #1983 (comment)

It feels odd that we have a `Checkout` button when you can't click it.
@zspencer
Copy link
Member

zspencer commented Dec 5, 2023

Oh dang, I saw the first one and the last one but didn't realize Cafe Gabriela had the issue too. It is odd for the Cafe Gabriela; I think it's likely that there are some Carts that we should delete now that we've stopped creating multiple Carts per Shopper. I'll go get rid of the carts in pre_checkout.

I've got a PR that removes the Checkout button completely as a kind of "stop-gap" because I didn't want to think about how to present a disabled Checkout button: #1999

zspencer added a commit that referenced this issue Dec 5, 2023
#1999)

- #1326
- #1983 (comment)

It feels odd that we have a `Checkout` button when you can't click it.
@zspencer
Copy link
Member

zspencer commented Dec 5, 2023

I've purged the other Carts that were in the pre_checkout state; and re-tested and it appears to work now?

@anaulin
Copy link
Member Author

anaulin commented Dec 6, 2023

Does seem to work now! (There is a separate bug about the delivery area saving not updating the cart, not sure if we have a separate issue to track that.)

@anaulin anaulin closed this as completed Dec 6, 2023
@zspencer
Copy link
Member

zspencer commented Dec 6, 2023

I've created an issue #2002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants