Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Marketplace: Buying Products: Switching Marketplaces should not destroy your Cart #1962

Closed
Tracked by #1326
zspencer opened this issue Nov 24, 2023 · 1 comment
Closed
Tracked by #1326

🐞 Marketplace: Buying Products: Switching Marketplaces should not destroy your Cart #1962

zspencer opened this issue Nov 24, 2023 · 1 comment
Labels
🐞 bug Something isn't working

Comments

@zspencer
Copy link
Member

zspencer commented Nov 24, 2023 •
edited
Loading

During Sutty's Heuristic Analysis, we discovered that if we open a new Marketplace the Cart from the previous Marketplace is gone!

Oops.
@zspencer zspencer added the 🐞 bug Something isn't working label Nov 24, 2023
@zspencer zspencer changed the title Marketplace: Switching between Marketplaces should not destroy your Cart 🐞 Marketplace: Switching between Marketplaces should not destroy your Cart Nov 24, 2023
@anaulin anaulin mentioned this issue Nov 30, 2023
Closed
11 tasks
zspencer added a commit that referenced this issue Dec 4, 2023
@zspencer
🐞🔨 Marketplace: Don't clear carts when navigating
eff5351 
- #1962

There was a bug we noticed during the Sutty demo where carts were being
cleared.

Turns out, if a `Marketplace` had multiple `DeliveryAreas` we would
create a new `Cart` for the shopper every time the page loaded. Womp.
Womp.
@zspencer zspencer mentioned this issue Dec 4, 2023
Merged
zspencer added a commit that referenced this issue Dec 4, 2023
@zspencer
🐞🔨 Marketplace: Don't clear Cart when switching Marketplaces (#…
64e1ad4 
…1992)

🐞🔨 `Marketplace`: Don't clear carts when navigating

- #1962

There was a bug we noticed during the Sutty demo where carts were being
cleared.

Turns out, if a `Marketplace` had multiple `DeliveryAreas` we would
create a new `Cart` for the shopper every time the page loaded. Womp.
Womp.
This was referenced Dec 4, 2023
Closed
Closed
@zspencer zspencer changed the title 🐞 Marketplace: Switching between Marketplaces should not destroy your Cart 🐞 Marketplace: Buying Products Switching Marketplaces should not destroy your Cart Dec 6, 2023
@zspencer
Copy link
Member Author

zspencer commented Dec 6, 2023

I have fixed this! Hooray!

@zspencer zspencer closed this as completed Dec 6, 2023
@zspencer zspencer changed the title 🐞 Marketplace: Buying Products Switching Marketplaces should not destroy your Cart 🐞 Marketplace: Buying Products: Switching Marketplaces should not destroy your Cart Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zspencer