This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
New configuration option: class_name_scalars #19
Merged
weierophinney
merged 9 commits into
zfcampus:master
from
michalbundyra:feature/class-name-scalars
Aug 13, 2016
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
92d4b00
Added new configuration option: `class_name_scalars`.
michalbundyra 46581e4
Consistency with commented out configuration options.
michalbundyra 0aefc20
Added .idea directory to .gitignore.
michalbundyra 8d4de04
Added `zend-servicemanager` as dev dependency.
michalbundyra 2f2f978
Updated CS rules + CS fixes.
michalbundyra 7036690
Fixed PHPDocs.
michalbundyra 8275fbd
Fixed syntax error in ConfigResourceFactory and added tests.
michalbundyra 244aacd
Added XML declaration in phpunit.xml.dist
michalbundyra 69cbbf2
Added trailing commas in arrays.
michalbundyra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
.idea/ | ||
vendor/ | ||
phpunit.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,7 @@ The top-level configuration key for user configuration of this module is `zf-con | |
'zf-configuration' => [ | ||
'config_file' => 'config/autoload/development.php', | ||
'enable_short_array' => false, | ||
'class_name_scalars' => false, | ||
], | ||
``` | ||
|
||
|
@@ -71,6 +72,10 @@ The top-level configuration key for user configuration of this module is `zf-con | |
Set this value to a boolean `true` if you want to use PHP 5.4's square bracket (aka "short") array | ||
syntax. | ||
|
||
#### Key: `class_name_scalars` | ||
|
||
Set this value to a boolean `true` if you want to use PHP 5.5's class name scalars (`::class` notation). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a bullet point: - Since 1.2.1 |
||
|
||
ZF2 Events | ||
---------- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,8 +33,9 @@ | |
"zendframework/zend-stdlib": "^2.7.7 || ^3.0.1" | ||
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "^4.8 || ^5.0", | ||
"squizlabs/php_codesniffer": "^2.3.1" | ||
"phpunit/phpunit": "^4.8 || ^5.5", | ||
"squizlabs/php_codesniffer": "^2.6.2", | ||
"zendframework/zend-servicemanager": "^2.7.6 || ^3.1.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this added? I'm not seeing it used in any of the new code. If anything, I'd expect to see container-interop as a dev dependency... |
||
}, | ||
"autoload": { | ||
"psr-4": { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add this in your own global
.gitignore
rules, not in the project rules.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many projects we have it so I thought it's ok