This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
New configuration option: class_name_scalars #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default set to `false`. If it will bet to `true` ConfigWriter (PhpArray writer) will use ::class notation on manipulating configuration files.
| @@ -1,2 +1,3 @@ | |||
| .idea/ | |||
There was a problem hiding this comment.
You should add this in your own global .gitignore rules, not in the project rules.
There was a problem hiding this comment.
In many projects we have it so I thought it's ok
| @@ -71,6 +72,10 @@ The top-level configuration key for user configuration of this module is `zf-con | |||
| Set this value to a boolean `true` if you want to use PHP 5.4's square bracket (aka "short") array | |||
| syntax. | |||
|
|
|||
| #### Key: `class_name_scalars` | |||
|
|
|||
| Set this value to a boolean `true` if you want to use PHP 5.5's class name scalars (`::class` notation). | |||
There was a problem hiding this comment.
Add a bullet point:
- Since 1.2.1
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2016
New configuration option: class_name_scalars
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2016
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2016
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2016
Forward port #19 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weierophinney as we discussed, added new configuration option:
class_name_scalars.By default is set to
false.When it is set to
trueConfigWriter will use::classnotation on writing to configuration files.In this PR also improvement some parts of the repository:
ConfigResourceFactory+ tests.