Separate engine failures from thrust limiter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in issue #1, I got TestFlight's implementation of engine thrust loss working in OhScrap.
TestFlight has a class called EngineModuleWrapper that abstracts the differences between a base-game engine module and a RealFuels/AJE engine. I brought the entire class over instead of trying to pick and choose what parts of it were relevant to this change.
We now have three different ways for an engine to lose thrust:
What OhScrap previously did with the thrust limiter: thrust decays by 10% every few seconds until it's effectively zero.
Fuel flow drops by 50%, causing the engine to deliver 50% thrust until repaired.
Specific impulse drops by 50%. The engine produces half thrust, but continues to consume as much fuel as it would at full thrust.