Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement engine under-thrust/under-Isp failures in a way that doesn't depend on thrust limiter. #1

Closed
bfrobin446 opened this issue Mar 11, 2020 · 1 comment · Fixed by #2
Closed

Implement engine under-thrust/under-Isp failures in a way that doesn't depend on thrust limiter. #1

bfrobin446 opened this issue Mar 11, 2020 · 1 comment · Fixed by #2
Assignees
@zer0Kerbal

Comments

@bfrobin446
Copy link

I plan to update the engine failure code to work with non-throttleable engines based on similar failure modes in TestFlight, as briefly discussed at severedsolo#23. Opening a ticket here to provide updates.
@bfrobin446 bfrobin446 mentioned this issue Mar 12, 2020
Merged
@zer0Kerbal
Copy link
Owner

#2 #2
recompiling - and updating beta now.

@zer0Kerbal zer0Kerbal self-assigned this Mar 15, 2020
@zer0Kerbal zer0Kerbal linked a pull request Mar 15, 2020 that will close this issue
Separate engine failures from thrust limiter #2
Merged
@zer0Kerbal zer0Kerbal added this to the Update engine under-thrust/under-Isp failures milestone Sep 16, 2021
zer0Kerbal added a commit that referenced this issue Sep 30, 2021
@zer0Kerbal
2.2.1.0-beta
86e5da5 
# Version 2.2.1.0-beta - *t-minus...the final countdown*

- 28 Sep 2021
- Release for Kerbal Space Program [KSP 1.12.2]
- recompile for KSP 1.12.2

-- sounds not included in this release. is a debug release so you will find extra items in the PAW. Not for live saves.

## Finally proper credit given to

- [@`Zelda'][LINK:zelda] for ideas and support. The legend is real! 🧧
- [`eightiesboi`][LINK:eightiesboi] for ideas, support and testing! 🧧

### Changed

- [Expat-MIT.txt]
  - rename from MIT.txt to Expat-MIT.txt to properly reference license type
  - update to include 2021
  - include contact information for zer0Kerbal (email address)
  - remove [@`magico13`][LINK:magico13] since he wasn't an author
- NETKan file updated

## Updated

- [_release.json] to 1.0.2.1 schema
- [Changelog.cfg] to most recent standard
- [readme.me] to most recent standard

## Added

- [us-en.cfg]
- initial code Localization #20 #27
- part failure sounds and settings
  - settings:
    - five soundfx selections
    - soundOn or Off on part failure
    - set to 0 for random sound
- start of localization 📚
  - us-en.cfg
- onGUI
  - GUI Hide on <F2> 🔟
- update Version.tt to 2.0.0.2
- new GameData/OhScrap/Sounds 📁
  - includes License.md (one file for all sound assets)
  - nine new sound clips

## New

- Failure Sounds #19
- Light Failure
- Decoupler Failures
- New settings

## Patch linting and file maintenance

- usual spring cleaning and automation
- update folder structure
- update to modern back-end automation

## Status

- Bug Issues / / Features
  - updated #20 #27 us-en.cfg should be complete
  - Used chutes fitted to ship are already deployed  #29
  - Implement engine under-thrust/under-Isp failures in a way that doesn't depend on thrust limiter. closes #1

- *** Possible future changes ***
  - ❓ ❔ the future : ❓ ❔
    - Clean the ScrapYard #12
    - Flowgraph Logspam #4
    - Used chutes fitted to ship are already deployed #3
    - add a wiki (user driven)
@settings settings bot removed the enhancement label Aug 11, 2022
@settings settings bot removed this from the Update engine under-thrust/under-Isp failures milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate engine failures from thrust limiter bfrobin446/OhScrap
2 participants
@bfrobin446 @zer0Kerbal