-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dts: arm: ti: Remove use of CONFIG_SOC_* from TI & Silabs SoC dts files #9946
dts: arm: ti: Remove use of CONFIG_SOC_* from TI & Silabs SoC dts files #9946
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9946 +/- ##
======================================
Coverage 52.5% 52.5%
======================================
Files 213 213
Lines 26078 26078
Branches 5624 5624
======================================
Hits 13691 13691
Misses 10136 10136
Partials 2251 2251 Continue to review full report at Codecov.
|
... from Zephyr's dts files, but I don't see how it points a way forward for users who are doing CONFIG_SOC_xxx ifdeffery in their dts overlays to do something similar in the future, if kconfig symbols like this are not available to the cpp invocation run on the dts. Am I missing something? |
I checked-out the PR, it builds, passes sanity, so looks OK to me. |
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
#define DT_SOC_EFR32FG1P133F256GM48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're to create additional dtsi files for SoC variants, I think the proposal in the first commit in cleaner
To move forward and remove use of Kconfig in dts files lets just create SoC specific dtsi files that the boards can include. This lets us remove: CONFIG_SOC_CC3220SF CONFIG_SOC_MSP432P401R Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
To move forward and remove use of Kconfig in dts files lets just create SoC specific dtsi files that the boards can include. This lets us remove: CONFIG_SOC_PART_NUMBER_EFM32WG990F256 CONFIG_SOC_PART_NUMBER_EFR32FG1P133F256GM48 Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
b7da692
to
6e6008d
Compare
To move forward and remove use of Kconfig in dts files lets just create
SoC specific dtsi files that the boards can include. This lets us
remove:
CONFIG_SOC_CC3220SF
CONFIG_SOC_MSP432P401R
Signed-off-by: Kumar Gala kumar.gala@linaro.org