Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: arm: ti: Remove use of CONFIG_SOC_* from TI & Silabs SoC dts files #9946

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

galak
Copy link
Collaborator

@galak galak commented Sep 12, 2018

To move forward and remove use of Kconfig in dts files lets just create
SoC specific dtsi files that the boards can include. This lets us
remove:

CONFIG_SOC_CC3220SF
CONFIG_SOC_MSP432P401R

Signed-off-by: Kumar Gala kumar.gala@linaro.org

@galak galak requested a review from erwango September 12, 2018 15:16
@galak galak requested a review from MaureenHelm as a code owner September 12, 2018 16:00
@galak galak changed the title dts: arm: ti: Remove use of CONFIG_SOC_* from TI SoC dts files dts: arm: ti: Remove use of CONFIG_SOC_* from TI & Silabs SoC dts files Sep 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #9946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9946   +/-   ##
======================================
  Coverage    52.5%   52.5%           
======================================
  Files         213     213           
  Lines       26078   26078           
  Branches     5624    5624           
======================================
  Hits        13691   13691           
  Misses      10136   10136           
  Partials     2251    2251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3259ac0...b7da692. Read the comment docs.

@mbolivar
Copy link
Contributor

This lets us remove:

CONFIG_SOC_CC3220SF
CONFIG_SOC_MSP432P401R

... from Zephyr's dts files, but I don't see how it points a way forward for users who are doing CONFIG_SOC_xxx ifdeffery in their dts overlays to do something similar in the future, if kconfig symbols like this are not available to the cpp invocation run on the dts. Am I missing something?

@GAnthony
Copy link
Collaborator

I checked-out the PR, it builds, passes sanity, so looks OK to me.
Though I'm not using overlays at the moment, @mbolivar raises a good question.

* SPDX-License-Identifier: Apache-2.0
*/

#define DT_SOC_EFR32FG1P133F256GM48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're to create additional dtsi files for SoC variants, I think the proposal in the first commit in cleaner

To move forward and remove use of Kconfig in dts files lets just create
SoC specific dtsi files that the boards can include.  This lets us
remove:

CONFIG_SOC_CC3220SF
CONFIG_SOC_MSP432P401R

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
To move forward and remove use of Kconfig in dts files lets just create
SoC specific dtsi files that the boards can include.  This lets us
remove:

CONFIG_SOC_PART_NUMBER_EFM32WG990F256
CONFIG_SOC_PART_NUMBER_EFR32FG1P133F256GM48

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak force-pushed the dts-remove-config-ifdefs branch from b7da692 to 6e6008d Compare September 14, 2018 13:51
@galak galak merged commit 912b4a2 into zephyrproject-rtos:master Sep 14, 2018
@galak galak deleted the dts-remove-config-ifdefs branch September 14, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants