Ipv4 cleanup #9088
Merged
Ipv4 cleanup #9088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2018 09:32
No need to initialize it to 0 as it will be set through given parameter. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Reduces the logic as well as the ipv4 header checksum needs to be computed either way. Fixes zephyrproject-rtos#8720 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
net_ipv4_finalize is always successful. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Codecov Report
@@ Coverage Diff @@
## master #9088 +/- ##
==========================================
- Coverage 52.46% 52.42% -0.04%
==========================================
Files 199 199
Lines 25063 25034 -29
Branches 5234 5236 +2
==========================================
- Hits 13150 13125 -25
+ Misses 9794 9789 -5
- Partials 2119 2120 +1
Continue to review full report at Codecov.
|
added 4 commits
July 24, 2018 15:01
Avoiding to re-create the IPv4 header into ICMPv4 code directly. Fixes zephyrproject-rtos#8720 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Through net_icmpv4_set_chksum() Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
net if core code will do it. Fixes zephyrproject-rtos#8720 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Static ones with that prefix, exported ones with net_icmpv4_ prefix. Fixes zephyrproject-rtos#8720 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
jukkar
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #8720