Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network stack cleanup: IPv4 #8720

Closed
tbursztyka opened this issue Jul 4, 2018 · 0 comments
Closed

Network stack cleanup: IPv4 #8720

tbursztyka opened this issue Jul 4, 2018 · 0 comments
Assignees
@tbursztyka
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Milestone
v1.13.0

Comments

@tbursztyka
Copy link
Collaborator

tbursztyka commented Jul 4, 2018 •
edited
Loading

ipv4.c has been reworked already.
icmpv4.c should be reworked:
. all ipv4 headers must be filled-in through net_ipv4_create (get rid of setup_ipv4_header)
. icmpv4 code should be using macro (or enum) so it's more readable than hard-coded numbers
. net_pkt_ll_src lines 317/318 should not be set here (net_if already handles the case, and set's current iface's ll address)

declutter using #8723 rules
@tbursztyka tbursztyka mentioned this issue Jul 4, 2018
Closed
7 tasks
@tbursztyka tbursztyka added this to the v1.13.0 milestone Jul 4, 2018
@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label Jul 4, 2018
tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue Jul 24, 2018
net/ipv4: Remove ifdefs and use IS_ENABLED instead
37068d0 
Reduces the logic as well as the ipv4 header checksum needs to be
computed either way.

Fixes zephyrproject-rtos#8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
@tbursztyka tbursztyka mentioned this issue Jul 24, 2018
Merged
@tbursztyka tbursztyka self-assigned this Jul 24, 2018
tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue Jul 24, 2018
net/icmpv4: Use generic IPv4 relevantly
d6f73d7 
Avoiding to re-create the IPv4 header into ICMPv4 code directly.

Fixes zephyrproject-rtos#8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue Jul 24, 2018
net/icmpv4: src ll address does not need to be set
d1bf77d 
net if core code will do it.

Fixes zephyrproject-rtos#8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue Jul 24, 2018
net/icmpv4: Rename static function with icmpv4_ prefix
d0952ba 
Static ones with that prefix, exported ones with net_icmpv4_ prefix.

Fixes zephyrproject-rtos#8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
@jukkar jukkar closed this as completed in a38dc09 Jul 24, 2018
jukkar pushed a commit that referenced this issue Jul 24, 2018
@jukkar
net/icmpv4: Use generic IPv4 relevantly
b89f127 
Avoiding to re-create the IPv4 header into ICMPv4 code directly.

Fixes #8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
jukkar pushed a commit that referenced this issue Jul 24, 2018
@jukkar
net/icmpv4: src ll address does not need to be set
ea5610a 
net if core code will do it.

Fixes #8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
jukkar pushed a commit that referenced this issue Jul 24, 2018
@jukkar
net/icmpv4: Rename static function with icmpv4_ prefix
9bb56cc 
Static ones with that prefix, exported ones with net_icmpv4_ prefix.

Fixes #8720

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbursztyka tbursztyka

Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
2 participants
@nashif @tbursztyka