Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: watchdog: align sample and test to new DT #12468

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

kl-cruz
Copy link
Collaborator

@kl-cruz kl-cruz commented Jan 14, 2019

Sample application and test are aligned to new DT naming convention.

Signed-off-by: Karol Lasończyk karol.lasonczyk@nordicsemi.no

@kl-cruz kl-cruz requested review from carlescufi and anangl January 14, 2019 14:24
@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #12468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12468   +/-   ##
=======================================
  Coverage   49.72%   49.72%           
=======================================
  Files         292      292           
  Lines       42425    42425           
  Branches     9968     9968           
=======================================
  Hits        21096    21096           
  Misses      17178    17178           
  Partials     4151     4151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f8f96...98fbb2c. Read the comment docs.

Copy link
Member

@anangl anangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are changes not in the nRF watchdog driver but in the sample and test for all watchdog drivers, so both the commit and PR should be titled "drivers: watchdog: Align ...".
The label CONFIG_WDT_0_NAME is still present in fixups for several SoCs. These occurrences should also be renamed. Hopefully, this renaming will make the CI green.

@kl-cruz
Copy link
Collaborator Author

kl-cruz commented Jan 15, 2019

@anangl Thanks for this. I'll check it and intruduce required changes

@kl-cruz kl-cruz requested a review from MaureenHelm January 15, 2019 08:49
@kl-cruz kl-cruz changed the title drivers: wdt: nrf: align sample and test to new DT drivers: watchdog: align sample and test to new DT Jan 15, 2019
@kl-cruz
Copy link
Collaborator Author

kl-cruz commented Jan 15, 2019

@MaureenHelm , Could you look at it? Small changes, but can be interesting for you!

@kl-cruz
Copy link
Collaborator Author

kl-cruz commented Jan 15, 2019

These are changes not in the nRF watchdog driver but in the sample and test for all watchdog drivers, so both the commit and PR should be titled "drivers: watchdog: Align ...".
The label CONFIG_WDT_0_NAME is still present in fixups for several SoCs. These occurrences should also be renamed. Hopefully, this renaming will make the CI green.

@anangl I fixed it in some other way. Please check my solution!

Sample application and test are aligned to new DT naming convention.

Signed-off-by: Karol Lasończyk <karol.lasonczyk@nordicsemi.no>
@MaureenHelm MaureenHelm merged commit c0a5739 into zephyrproject-rtos:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants