Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchdog sample application not being built on Nordic devices #11779

Closed
pabigot opened this issue Nov 30, 2018 · 3 comments
Closed

watchdog sample application not being built on Nordic devices #11779

pabigot opened this issue Nov 30, 2018 · 3 comments
Assignees
@kl-cruz @galak @anangl @Mierunski
Labels
area: Drivers area: Watchdog Watchdog bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: low Low impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Nov 30, 2018

In PR #10377 the nrf infrastructure switched to using a device tree alias for watchdog, including changing the dts_fixup to use DT_WDT_0_NAME.

Unfortunately the change was isolated to the Nordic driver code, with a consequence that samples/drivers/watchdog no longer builds on Nordic hardware. All other platforms that support watchdog are still using CONFIG_WDT_0_NAME, as does the driver API test application.
@carlescufi carlescufi added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Drivers area: Watchdog Watchdog platform: nRF Nordic nRFx labels Dec 3, 2018
@carlescufi
Copy link
Member

@anangl @kl-cruz would you please take a look at this?

@kl-cruz
Copy link
Collaborator

kl-cruz commented Dec 11, 2018

Okay, it should be only code alignment

@galak galak changed the title watchdog sample application broken on Nordic devices watchdog sample application not being built on Nordic devices Dec 13, 2018
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 15, 2019

Should be resolved by #12468.

@pabigot pabigot closed this as completed Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kl-cruz kl-cruz

@galak galak

@anangl anangl

@Mierunski Mierunski

Labels
area: Drivers area: Watchdog Watchdog bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pabigot @kl-cruz @carlescufi @galak @anangl @Mierunski