Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZendEngine3::zend_generator_create_zval #1337

Closed
sergeyklay opened this issue Oct 10, 2016 · 2 comments
Closed

ZendEngine3::zend_generator_create_zval #1337

sergeyklay opened this issue Oct 10, 2016 · 2 comments
Labels
bug

Comments

@sergeyklay
Copy link
Contributor

sergeyklay commented Oct 10, 2016 •
edited by phalcon
Loading

The ZendEngine3 kernel use outdated zend_generator_create_zval.
https://github.com/phalcon/zephir/blob/master/kernels/ZendEngine3/extended/fcall.c#L167

This function is no longer present in ZendEngine 3:
https://github.com/php/php-src/blob/master/Zend/zend_generators.h

Refs: phalcon/cphalcon#12055 (comment)
@sergeyklay sergeyklay added the bug label Oct 10, 2016
@andresgutierrez
Copy link
Contributor

It was removed in php 7.1?

@sergeyklay
Copy link
Contributor Author

@andresgutierrez As I can see yes
php/php-src@ccf18da

@sergeyklay sergeyklay mentioned this issue Oct 11, 2016
Closed
sergeyklay added a commit that referenced this issue Oct 14, 2016
@sergeyklay
Merge pull request #1338 from dreamsxin/zend_generator_create_zval
23856e1 
Fixed #1337 #12055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andresgutierrez @sergeyklay