Broken build with PHP 7.1 #12055

remicollet · 2016-07-30T17:57:58Z

With 7.1.0beta1

/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c: In function 'zephir_get_called_class':
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c:4764:45: error: 'struct _zend_execute_data' has no member named 'called_scope'
  if (EG(current_execute_data)->called_scope) {
                                             ^
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c:4765:61: error: 'struct _zend_execute_data' has no member named 'called_scope'
   zend_string *ret = EG(current_execute_data)->called_scope->name;
                                                             ^
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c:4770:24: error: 'zend_executor_globals {aka struct _zend_executor_globals}' has no member named 'scope'
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c: In function 'zephir_read_property':
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c:5069:31: error: 'zend_executor_globals {aka struct _zend_executor_globals}' has no member named 'scope'
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c:5070:19: error: 'zend_executor_globals {aka struct _zend_executor_globals}' has no member named 'scope'
/builddir/build/BUILD/cphalcon-5372ac7972218b10fd9f08027a7718ea10f191b5/build/NTS/phalcon.zep.c:5090:19: error: 'zend_executor_globals {aka struct _zend_executor_globals}' has no member named 'scope'
  EG(scope) = old_scope;
                   ^
...

The text was updated successfully, but these errors were encountered:

remicollet · 2016-07-30T17:59:29Z

This fix in yaf extension gives a part of solution ;)

laruence/yaf@bd6ffea

dreamsxin · 2016-10-10T06:52:54Z

Can upgrade zephir, rebuild phalcon it's ok.

remicollet · 2016-10-10T08:57:25Z

Better, but still broken with latest zephy snapshot (22f6632)

Build:

/builddir/build/BUILD/cphalcon-23b4100faa3ef91863d7f05de3f1c7a450cd52bc/build/ZTS/phalcon.zep.c: In function 'zephir_call_func_aparams_fast':
/builddir/build/BUILD/cphalcon-23b4100faa3ef91863d7f05de3f1c7a450cd52bc/build/ZTS/phalcon.zep.c:6828:4: warning: implicit declaration of function 'zend_generator_create_zval' [-Wimplicit-fun

Load:
PHP Warning: PHP Startup: Unable to load dynamic library '/builddir/build/BUILDROOT/php-phalcon3-3.0.1-1.fc23.remi.7.1.x86_64/usr/lib64/php/modules/phalcon.so' - /builddir/build/BUILDROOT/php-phalcon3-3.0.1-1.fc23.remi.7.1.x86_64/usr/lib64/php/modules/phalcon.so: undefined symbol: zend_generator_create_zval in Unknown on line 0

dreamsxin · 2016-10-11T00:54:13Z

@remicollet Whether delete ext/kernel directory in phalcon source

remicollet · 2016-10-11T05:32:32Z

@dreamsxin same error.

sergeyklay · 2016-10-11T05:40:27Z

@dreamsxin zephir-lang/zephir#1337

dreamsxin · 2016-10-11T23:12:30Z

@sergeyklay Get it.

sergeyklay · 2016-10-14T12:53:39Z

@remicollet Could you please try now by using the latest Zephir from master branch?

git clone git@github.com:phalcon/cphalcon.git
cd cphalcon
git checkout 3.0.x

zephir fullclean
zephir build

remicollet · 2016-10-14T13:32:17Z

Tagged version 3.0.1 NTS build fine with latest zephyr (0.9.4 rev 23856e1)

$ /usr/bin/php --no-php-ini -d extension=json.so -d extension=pdo.so --define extension=/builddir/build/BUILDROOT/php-phalcon3-3.0.1-1.fc23.remi.7.1.x86_64/usr/lib64/php/modules/phalcon.so --modules
+ grep -i phalcon
phalcon

But not the ZTS one

+ /usr/bin/zts-php --no-php-ini -d extension=json.so -d extension=pdo.so --define extension=/builddir/build/BUILDROOT/php-phalcon3-3.0.1-1.fc23.remi.7.1.x86_64/usr/lib64/php-zts/modules/phalcon.so --modules
+ grep -i phalcon

Strange... no error message...

Jurigag · 2016-10-14T13:35:01Z

Did you compile phalcon for zts ? ZTS php is totally different php and you need to install phalcon separately for it. I mean you sure this path even exists like /builddir/build/BUILDROOT/php-phalcon3-3.0.1-1.fc23.remi.7.1.x86_64/usr/lib64/php-zts/modules/phalcon.so ?

Check syslog or something then.

remicollet · 2016-10-14T13:40:00Z

Did you compile phalcon for zts ?

Yes, like all other >160 extensions I build ;)

Jurigag · 2016-10-14T13:41:53Z

Then check any logs maybe ? Maybe some seg fault or something.

remicollet · 2016-10-14T13:57:29Z

This also happen for NTS build on some distro (RHEL-6 and 7, not on Fedora...)

Jurigag · 2016-10-14T14:01:11Z

Anything in logs ?

remicollet · 2016-10-14T14:06:20Z

Read previous comments => "no error message."

Jurigag · 2016-10-14T14:07:17Z

I wasn't asking for error message, i was asking for logs, like syslog etc.

remicollet · 2016-11-27T08:01:42Z

v3.0.2 using latest zephyr cae68c4205a93a7a1ea6165bcd5ce5cb470f5bdd still broken.

PHP 7.1.0 is planed for Dec 1st.

sergeyklay · 2016-11-27T16:51:21Z

@remicollet https://seld.be/notes/php-versions-stats-2016-2-edition

In my opinion there are many enterprise/corporate projects. They use Composer more rarely. So the proportion of the 5th version is bigger.

And when someone asks me about 7.1 (before release) it sounds strange to me.

The time is our resource; We can spend it either for fixing bugs and stabilizing the work, or for supporting 7.1 (which will be used by 1% of users)

Jurigag · 2016-11-27T16:55:45Z

First of all, is there any really crucial and needed advantage in php 7.1 so we need to support it as soon as possible ?

Izopi4a · 2016-12-05T22:29:59Z

I agree with @sergeyklay, just one thing is that "new users" that are seeking for php framework might get pushed away by a fact that a specific framework doesn`t support the "latest php".

While i don`t say this is the most important issue i still think it should be fixed at early stage so people can see framework is always up to date and they have nothing to worry about.

At least , this is what i think

temuri416 · 2016-12-06T15:21:14Z

@Jurigag @sergeyklay Do I understand it correctly that at the moment Phalcon 3.0,2 will not compile with PHP 7.1?

I did try it, and got segfaults - so that's not a good sign. Prevents us from moving to PHP 7.1.

Jurigag · 2016-12-06T16:11:21Z

Yes. Just stay at php 7 until this is fixed.

kornrunner · 2016-12-07T09:40:59Z

We're using phalcon in production on PHP 7 and we'd like to upgrade to 7.1, so looking forward to these changes.

Thanks!

Rid · 2017-03-23T12:23:13Z

+1 for a fix, would like to go to 7.1

Jurigag · 2017-03-23T12:40:19Z

It will be really soon i think.

drnasin · 2017-03-23T17:50:05Z

+1 for a fix, would like to go to 7.1

Jurigag · 2017-03-27T22:39:26Z

It's theoritcally fixed here - #12747 on build using latest zephir

Though it could be nice if someone with big test suite in their application could test it before we release it:

// install php 7.1 and 7.1-dev
git clone https://github.com/phalcon/zephir
cd zephir
./install -c
cd ..
git clone https://github.com/phalcon/cphalcon
cd cphalcon
git checkout 3.1.x
zephir build
// run your tests

sergeyklay · 2017-04-05T12:54:16Z

Fixed in the 3.1.x branch. Note: You have to use latest Zephir from master branch

remicollet · 2017-04-05T13:27:14Z

@sergeyklay do you plan to tag a new Zephir release ?
(also hard to find which version should be used..., using tag seems the one safe way)

At least before 3.1.x next version

Jurigag · 2017-04-05T13:38:22Z

3.1.2 will be released on few days so there will be no need to use zephir. Just use master zephir.

remicollet · 2017-04-05T13:40:23Z

Just use master zephir.

Please tag.

Jurigag · 2017-04-05T13:42:26Z

What's a problem with master? Zephir is still being fixed etc, changes are happening almost each day so i don't see a point with a tag.

remicollet · 2017-04-05T13:46:36Z

What's a problem with master?

Building a stable version (phalcon 3.1.2) with a unstable Zephir snapshot seems... messy, ugly, and terribly bad practice.

Jurigag · 2017-04-05T13:47:19Z

But 3.1.x is not stable version either.

remicollet · 2017-04-05T13:48:43Z

From https://github.com/phalcon/cphalcon/releases 3.1.1 is Latest Release, so I suppose it is "stable", thus will be upcoming 3.1.2, when tagged...

Definitively, I think I will never understand how this project works.

Jurigag · 2017-04-05T13:51:59Z

When 3.1.2 will be released you won't need zephir to install it. To install latest NOT STABLE phalcon you need zephir, what's a difference if you will compile unstable phalcon with stable or non-stable zephir?

remicollet · 2017-04-05T13:57:58Z

When 3.1.2 will be released you won't need zephir to install it.

I'm used to rebuild from tagged sources, using zephir, at least because I need to patch sources to drop the damned fucking non-free part (2 years old bug #10118)

Jurigag · 2017-04-05T13:59:45Z

Oh okay then.

sergeyklay · 2017-04-05T14:34:08Z

@remicollet No problem. We'll release new Zephir version

remicollet · 2017-04-05T14:36:52Z

thanks

sergeyklay · 2017-04-05T15:37:43Z

Released

remicollet · 2017-04-05T16:14:56Z

Released

I can even confirm, phalcon 3.1.1 build without any issue using zephir 0.9.7.

So, added to the few extensions list I can provide as RPM in my repo (for Fedora / RHEL and CentOS).

niden · 2017-04-05T18:11:31Z

Thank you for all the help @remicollet

xueron · 2017-04-06T04:25:07Z

Good news :)

drnasin · 2017-04-06T08:59:54Z

thank you boys!

sergeyklay added the Bug - Medium label Aug 1, 2016

sergeyklay added this to the 3.1.0 milestone Aug 1, 2016

sergeyklay assigned andresgutierrez Aug 3, 2016

sergeyklay added the PHP 7 label Oct 10, 2016

sergeyklay mentioned this issue Oct 10, 2016

ZendEngine3::zend_generator_create_zval zephir-lang/zephir#1337

Closed

dreamsxin mentioned this issue Oct 14, 2016

Fixed #1337 #12055 zephir-lang/zephir#1338

Merged

sergeyklay mentioned this issue Dec 6, 2016

can't start the php7.1 server when i update the php7 to php7.1 with the phalcon #12457

Closed

sergeyklay unassigned andresgutierrez Mar 23, 2017

sergeyklay modified the milestones: 3.2.0, 3.1.x Mar 23, 2017

sergeyklay mentioned this issue Mar 24, 2017

Remove php 7.1 from allowed failures #12747

Merged

3 tasks

sergeyklay closed this as completed Apr 5, 2017

niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019

Broken build with PHP 7.1 #12055

Broken build with PHP 7.1 #12055

Comments

remicollet commented Jul 30, 2016

remicollet commented Jul 30, 2016 • edited Loading

dreamsxin commented Oct 10, 2016

remicollet commented Oct 10, 2016 • edited Loading

dreamsxin commented Oct 11, 2016

remicollet commented Oct 11, 2016

sergeyklay commented Oct 11, 2016

dreamsxin commented Oct 11, 2016

sergeyklay commented Oct 14, 2016 • edited Loading

remicollet commented Oct 14, 2016

Jurigag commented Oct 14, 2016 • edited Loading

remicollet commented Oct 14, 2016

Jurigag commented Oct 14, 2016

remicollet commented Oct 14, 2016

Jurigag commented Oct 14, 2016

remicollet commented Oct 14, 2016

Jurigag commented Oct 14, 2016

remicollet commented Nov 27, 2016

sergeyklay commented Nov 27, 2016

Jurigag commented Nov 27, 2016 • edited by sergeyklay Loading

Izopi4a commented Dec 5, 2016

temuri416 commented Dec 6, 2016

Jurigag commented Dec 6, 2016

kornrunner commented Dec 7, 2016

Rid commented Mar 23, 2017

Jurigag commented Mar 23, 2017

drnasin commented Mar 23, 2017

Jurigag commented Mar 27, 2017 • edited by sergeyklay Loading

sergeyklay commented Apr 5, 2017 • edited Loading

remicollet commented Apr 5, 2017

Jurigag commented Apr 5, 2017

remicollet commented Apr 5, 2017

Jurigag commented Apr 5, 2017 • edited Loading

remicollet commented Apr 5, 2017 • edited Loading

Jurigag commented Apr 5, 2017 • edited Loading

remicollet commented Apr 5, 2017 • edited Loading

Jurigag commented Apr 5, 2017 • edited Loading

remicollet commented Apr 5, 2017 • edited Loading

Jurigag commented Apr 5, 2017

sergeyklay commented Apr 5, 2017

remicollet commented Apr 5, 2017

sergeyklay commented Apr 5, 2017

remicollet commented Apr 5, 2017

niden commented Apr 5, 2017

xueron commented Apr 6, 2017

drnasin commented Apr 6, 2017

remicollet commented Jul 30, 2016 •

edited

Loading

remicollet commented Oct 10, 2016 •

edited

Loading

sergeyklay commented Oct 14, 2016 •

edited

Loading

Jurigag commented Oct 14, 2016 •

edited

Loading

Jurigag commented Nov 27, 2016 •

edited by sergeyklay

Loading

Jurigag commented Mar 27, 2017 •

edited by sergeyklay

Loading

sergeyklay commented Apr 5, 2017 •

edited

Loading

Jurigag commented Apr 5, 2017 •

edited

Loading

remicollet commented Apr 5, 2017 •

edited

Loading

Jurigag commented Apr 5, 2017 •

edited

Loading

remicollet commented Apr 5, 2017 •

edited

Loading

Jurigag commented Apr 5, 2017 •

edited

Loading

remicollet commented Apr 5, 2017 •

edited

Loading