-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few warnings to the connection switcher and conf parser #143
Conversation
... better double-check shards in kubernetes are integers first... I'll update here once I checked |
kk, all good! |
dff290d
to
92890a4
Compare
0079c79
to
2a1721d
Compare
2a1721d
to
a157c0c
Compare
Add a few warnings to the connection switcher and conf parser
Add a few warnings to the connection switcher and conf parser
This was a breaking change to the gem for everyone using strings to name the shards. |
I think this was about sanitizing inputs ... I guess casting to int would have worked too. |
yeah sounds reasonable, can you make a PR that semi-reverts this one and allows strings ? |
@bquorning @grosser |
I think this is because we only use it with integers and we wanted to warn our users from misconfiguration |
Mostly extracted from #136.