All shard names must be integers

[rossi-jeff]

my first reaction was 'what??'

trying to evaluate your gem as a replacement for octopus which does not work with rails 5.2

is it possible to use named shards without forking the gem?

[vaibhavpaliwal]

Yes, its possible.. in my project we use guids something like below:

  shards:
    asdd13-c755-478d-b343-sdf900203:
      database: test
    asddw-123451-484e-b0d3-uahf2738:
      database: abc

[rossi-jeff]

did you need to comment out any checks in order to do that?

shards:
     alpha:
         database: db1
     beta:
        database: db2

and got the above error

[holmes2]

I am still getting the error when my shard names are uuids. Any possible explanation on how to get around the issue ?

[grosser]

try opening up the gem and see where the validation comes from, then try to disable it ... best as opt-in

[holmes2]

@grosser
Can i open up PR for it on the repo ? Is that something which the gem would also benefit from the changes which I make ?

[grosser]

with opening up the gem I meant bundle open active_record_shards to poke around in it / find the error location
but yeah, please open a PR here if you know what needs to change

[holmes2]

@grosser I have tried to only comment out the checks and see if that works in the rails service. On initial test it was working fine. Other than the integer checks is there any other place where the gem assumes integers and fails ? I can try to find in the gem rspecs but needed some guidance into what might be get messed up in the gem if i provide strings.

[grosser]

I don't think there are any other hardcoded checks in there.

…

On Wed, Aug 19, 2020 at 8:07 AM Priyank Kapadia ***@***.***> wrote: @grosser <https://github.com/grosser> I have tried to only comment out the checks and see if that works in the rails service. On initial test it was working fine. Other than the integer checks is there any other place where the gem assumes integers and fails ? I can try to find in the gem rspecs but needed some guidance into what might be get messed up in the gem if i provide strings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZ7A2SYGMHM5Q5LMIATSBPTDVANCNFSM4FLOHQFA>.