windows: Fix rust-analyzer download #20408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @ArthurBrussee on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
SomeoneToIgnore
approved these changes
Nov 12, 2024
| match Self::GITHUB_ASSET_KIND { | ||
| AssetKind::TarGz => { | ||
| let decompressed_bytes = GzipDecoder::new(BufReader::new(response.body_mut())); | ||
| let archive = async_tar::Archive::new(decompressed_bytes); |
There was a problem hiding this comment.
Idk how I've missed this, but TarGz != Gz (our case as noted just above).
SomeoneToIgnore
added a commit
that referenced
this pull request
Nov 15, 2024
Follow-up of #20408 Release Notes: - (Preview) Fixed broken rust-analyzer downloads
SomeoneToIgnore
added a commit
that referenced
this pull request
Nov 15, 2024
Follow-up of #20408 Release Notes: - (Preview) Fixed broken rust-analyzer downloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rust-lang/rust-analyzer#18412, there is no longer a .gz file for windows rust-analyzer targets, and the rust analyzer LSP fails to download. This fixes it by using the .zip version on windows.
The .zip also extracts to a folder containing rust-analyzer.exe rather than just a file. I've handled it in this code, but am not 100% sure if other parts of the code need too be aware of it.
Release Notes: