internal: Stop producing .gz artifacts for Windows #18412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
approved these changes
Oct 25, 2024
|
I'll merge this on Monday, to get a note about it in the release notes. |
|
Not that the change matters to me, but I'm curious to know the rationale. |
|
ZIP files are nicer because they preserve the executable flag (relevant on Unix) and original file name (e.g. #9469, but there were others). And we were already producing Windows ZIP artifacts since forever, so no point in keeping around extra files. As a bonus, they also contain debug symbols. |
|
Oh I see, I missed the fact that it was really just a |
|
Yeah, and at some point Windows was shipping a |
SomeoneToIgnore
pushed a commit
to zed-industries/zed
that referenced
this pull request
Nov 12, 2024
After rust-lang/rust-analyzer#18412, there is no longer a .gz file for windows rust-analyzer targets, and the rust analyzer LSP fails to download. This fixes it by using the .zip version on windows. The .zip also extracts to a _folder_ containing rust-analyzer.exe rather than just a file. I've handled it in this code, but am not 100% sure if other parts of the code need too be aware of it. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.