Tailor fails to parse template with comments inside

[DeTeam]

For some reason tailor fails to parse templates with HTML comments inside.

Judging by the error message and some snippets in the code, it seem like handling of comments is different from how other tags are processed.

     TypeError: Cannot destructure property `slot` of 'undefined' or 'null'.
      at nodes.forEach.node (lib/transform.js:56:51)
      at Array.forEach (<anonymous>)
      at Transform._groupSlots (lib/transform.js:54:15)
      at Transform.applyTransforms (lib/transform.js:32:24)
      at Promise.resolve.then.transform (lib/parse-template.js:19:19)
      at <anonymous>

[codecov]

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          14       14           
  Lines         586      586           
  Branches      104      104           
=======================================
  Hits          576      576           
  Misses         10       10

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681aed5...05eec49. Read the comment docs.

[ruiaraujo]

👍

[DeTeam]

👍

[DeTeam]

/cc @vigneshshanmugam, check once you're back :)

[vigneshshanmugam]

should not be handled in this way..

This fix mean would completely skip comment nodes from child templates which is not the expected output.

[ruiaraujo]

ok, so why do we handle text nodes like?

Tomorrow I will take a look on passing it through.

[DeTeam]

ok, so why do we handle text nodes like?

yup, that was a bit puzzling, thus was thinking it's ok to have comments handled the same way

[vigneshshanmugam]

Totally forgot why i did it that way. Will update once i remember.

But, with the fix #195, we can even include text nodes(space) as part of child templates.