Merge pull request #191 from zalando/tailor-parsting-failure

Tailor fails to parse template with comments inside
zalando · Oct 20, 2017 · 832f078 · 832f078
2 parents 681aed5 + 05eec49
commit 832f078
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/transform.js b/lib/transform.js
@@ -52,7 +52,10 @@ module.exports = class Transform {
         const slotMap = new Map([['default', []]]);
         const nodes = treeAdapter.getChildNodes(root);
         nodes.forEach(node => {
-            if (!treeAdapter.isTextNode(node)) {
+            if (
+                !treeAdapter.isTextNode(node) &&
+                !treeAdapter.isCommentNode(node)
+            ) {
                 const { slot = 'default' } = node.attribs;
                 const slotNodes = slotMap.get(slot) || [];
                 const updatedSlotNodes = [...slotNodes, node];

diff --git a/tests/parse-template.js b/tests/parse-template.js
@@ -14,4 +14,10 @@ describe('parseTemplate', () => {
             assert(err instanceof Error);
         });
     });
+
+    it('should parse templates with comments inside', done => {
+        parseTempatePartial('<div></div>', '<!-- nice comment -->')
+            .then(() => done())
+            .catch(done);
+    });
 });