Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): move chart release workflow and fix fetch-depth bug #326

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix(workflow): move chart release workflow and fix fetch-depth bug #326

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48342b7
chore: move Helm chart release steps to chart-release.yml and fix fet…
Yuni-sa Jun 27, 2024
ba802cd
action lint
Yuni-sa Jun 27, 2024
1ec6858
remove token from helm setup
Yuni-sa Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/chart-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Release Charts
on:
push:
tags:
- "*"
jobs:
chart-release:
name: Chart Release
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Configure Git
run: |
git config user.name "$GITHUB_ACTOR"
git config user.email "$GITHUB_ACTOR@users.noreply.github.com"

- name: Install Helm
uses: azure/setup-helm@v4
env:
GITHUB_TOKEN: "${{ secrets.RELEASE_GITHUB_TOKEN }}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the token for install helm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The token is no longer needed. It was previously required to fetch the latest version, but that's not the case anymore.
Azure/setup-helm#130.


- name: Run chart-releaser
uses: helm/chart-releaser-action@v1.6.0
env:
CR_TOKEN: "${{ secrets.RELEASE_GITHUB_TOKEN }}"
10 changes: 0 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,3 @@ jobs:
- name: Update new version in krew-index
uses: rajatjindal/krew-release-bot@v0.0.46

- name: Configure Git
run: |
git config user.name "$GITHUB_ACTOR"
git config user.email "$GITHUB_ACTOR@users.noreply.github.com"

- name: Run chart-releaser
uses: helm/chart-releaser-action@v1.6.0
env:
CR_TOKEN: "${{ secrets.RELEASE_GITHUB_TOKEN }}"

Loading