fix(workflow): move chart release workflow and fix fetch-depth bug #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-depth bug - Moved the Helm chart release steps from release.yml to a new chart-release.yml workflow for better separation of concerns. - Fixed a bug where the chart-releaser-action wouldn't find changes by adding fetch-depth: 0 in the checkout step.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 42.01% 42.01%
=======================================
Files 61 61
Lines 3175 3175
=======================================
Hits 1334 1334
Misses 1633 1633
Partials 208 208 ☔ View full report in Codecov by Sentry. |
yonahd
reviewed
Jun 28, 2024
.github/workflows/chart-release.yml
Outdated
| - name: Install Helm | ||
| uses: azure/setup-helm@v4 | ||
| env: | ||
| GITHUB_TOKEN: "${{ secrets.RELEASE_GITHUB_TOKEN }}" |
There was a problem hiding this comment.
Do we need the token for install helm?
There was a problem hiding this comment.
Good catch! The token is no longer needed. It was previously required to fetch the latest version, but that's not the case anymore.
Azure/setup-helm#130.
|
@Yuni-sa I added a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
PR Checklist
GitHub Issue
Closes #325
Notes for your reviewers
release.ymltochart-release.ymlfor better separation of concerns and to avoid slowing down the main CI process withfetch-depth: 0.