Feat/add rest and transitionstart events #207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
rest
event and correspondingrestEpsilon
parameter discussed in #206.Also added a new
rest-and-sleep
example to show the difference between the two events, and updated the readme.While making the example, I discovered there was no way to reliably disable the buttons when starting a new transition using one of the buttons (which call
.rotateTo
and.dollyTo
) - so I added an additional event,transitionstart
. This fires whenever any kind of transition is started, which can be either a user input or a method withenableTransition = true
.I originally wanted
transitionstart
to fire only for a method withenableTransition = true
, but not for user control. However, internally user controls use methods such as.rotate
so there's currently no way to differentiate these. Probably that's ok though.I checked in
dist/
by mistake, let me know if you want me to remove it to make the code easier to review.