-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Make transitions thenable #206
Comments
Hi @looeee, If you'd like to control a CameraControls instance as tweens, you could combine a tween library, e.g.
What do you think...? |
😊 Thank you for this awesome library.
Yeah for sure, I'm using Popmotion at the moment. Actually it was GSAP's new version that inspired me to make this request, their tweens return promises now which makes writing animations much cleaner. No more
Yeah, this is the difficult one for knowing when an animation has completed. I explored the code a bit more since I made this issue and I see why it would be a bit hard to implement. The problem is If Another alternative would be a completely new event that fires before sleep but when the movement is less than some epsilon in a single frame. |
Yeah, actually I think so...
Both sound good! |
Haha love it 😄 Maybe |
Make sense! Are you interested in contributing to the code? or maybe next? |
I can do it if you don't mind waiting for a few days :) |
Cool! |
Is your feature request related to a problem? Please describe.
controls.rotateTo
.Describe alternatives you've considered
I've tried doing this using the event listeners
wake
andsleep
however the problem is:a) it's hard to distinguish an animation from a user interaction
b) due to damping
sleep
fires far too lateThe text was updated successfully, but these errors were encountered: