Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToJavascript instance of String and Text #227

Merged
merged 3 commits into from
Sep 25, 2018
Merged

ToJavascript instance of String and Text #227

merged 3 commits into from
Sep 25, 2018

Conversation

pythonissam
Copy link

No description provided.

@pythonissam
Copy link
Author

issue ref: #226

@pythonissam pythonissam changed the title Text instance of string text Text instance of String and Text Sep 21, 2018
snoyberg
snoyberg requested changes Sep 21, 2018
View reviewed changes
ChangeLog.md Outdated
@@ -1,3 +1,7 @@
### 2.0.18

* Text instance of String and Text [#227](https://github.com/yesodweb/shakespeare/pull/227)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say ToJavascript instance, and point out that it's for both strict and lazy Text.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should say ToJavascript instance for String, Strict and Lazy Text. Right now, it says Text instance for .... instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um sorry, I'm not good at English. lol

@pythonissam pythonissam force-pushed the text-instance-of-string-text branch from 06b7684 to b913f78 Compare September 24, 2018 04:25
@pythonissam pythonissam force-pushed the text-instance-of-string-text branch from b913f78 to 43475fe Compare September 24, 2018 06:26
@pythonissam pythonissam changed the title Text instance of String and Text ToJavascript instance of String and Text Sep 24, 2018
@snoyberg snoyberg merged commit 3c98c4c into yesodweb:master Sep 25, 2018
@snoyberg
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psibi psibi psibi left review comments

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pythonissam @snoyberg @psibi