Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable interpolation in Julius? #226

Closed
pythonissam opened this issue Sep 17, 2018 · 2 comments
Closed

Variable interpolation in Julius? #226

pythonissam opened this issue Sep 17, 2018 · 2 comments

Comments

@pythonissam
Copy link

Currently, there's no ToJavascript instance of String and Text. I've read this blog post. It says:

Down the road, it will likely make sense to add in ToJavascript instances for common types which first convert to JSON. However, doing so in this first release would mean that old code would silently change its semantics.

Still need to consider backwards compatibility?
@snoyberg
Copy link
Member

I think I'd be OK with such a change at this point, PR welcome.

@pythonissam
Copy link
Author

OK, I'll submit it.

@pythonissam pythonissam mentioned this issue Sep 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyberg @pythonissam